Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(apigatewayv2): disallow allowCredentials when allowOrigin has '*' #9415

Merged
merged 1 commit into from
Aug 3, 2020
Merged

chore(apigatewayv2): disallow allowCredentials when allowOrigin has '*' #9415

merged 1 commit into from
Aug 3, 2020

Conversation

nija-at
Copy link
Contributor

@nija-at nija-at commented Aug 3, 2020

closes #9076

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@nija-at nija-at requested a review from a team August 3, 2020 14:22
@nija-at nija-at self-assigned this Aug 3, 2020
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Aug 3, 2020
@mergify
Copy link
Contributor

mergify bot commented Aug 3, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 3fdd8be into master Aug 3, 2020
@mergify mergify bot deleted the nija-at/apigwv2-corscheck branch August 3, 2020 14:38
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 7c7129e
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

eladb pushed a commit that referenced this pull request Aug 10, 2020
chore(apigatewayv2): disallow allowCredentials when allowOrigin has '…
e01f663 
…*' (#9415)

closes #9076


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
curtiseppel pushed a commit to curtiseppel/aws-cdk that referenced this pull request Aug 11, 2020
chore(apigatewayv2): disallow allowCredentials when allowOrigin has '…
684e335 
…*' (aws#9415)

closes aws#9076


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njlynch njlynch njlynch approved these changes

Assignees

@nija-at nija-at

Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[apigatewayv2] Cors Docs example result in 400
3 participants
@nija-at @aws-cdk-automation @njlynch