-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(appsync): add x-ray parameter to AppSync #9389
Changes from 2 commits
6775110
aaf8a7b
3ec3a51
2ae7836
ac4c152
3ad8e8e
ec0c3bf
136cad8
fecdc62
93aaa8d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -238,6 +238,12 @@ export interface GraphQLApiProps { | |||||
* @default - Use schemaDefinition | ||||||
*/ | ||||||
readonly schemaDefinitionFile?: string; | ||||||
/** | ||||||
* A flag indicating whether or not X-Ray tracing is enabled for the GraphQL API. | ||||||
* | ||||||
* @default - false | ||||||
*/ | ||||||
readonly xrayEnabled?: boolean; | ||||||
|
||||||
} | ||||||
|
||||||
|
@@ -383,6 +389,7 @@ export class GraphQLApi extends Construct { | |||||
) | ||||||
: undefined, | ||||||
additionalAuthenticationProviders: this.formatAdditionalAuthenticationProviders(props), | ||||||
xrayEnabled: props.xrayEnabled || false, | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The property doesn't need to be configured here. If it is undefined in CloudFormations, Cfn will configure the AppSync without x-ray support by default.
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @BryanPan342 |
||||||
}); | ||||||
|
||||||
this.apiId = this.api.attrApiId; | ||||||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -94,7 +94,8 @@ | |
"UserPoolId": { | ||
"Ref": "PoolD3F588B8" | ||
} | ||
} | ||
}, | ||
"XrayEnabled": false | ||
} | ||
}, | ||
"ApiSchema510EECD7": { | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would rather us either put a description of what x-ray support is or not include it at all in the README.
Since it is a feature, I think in order to avoid the linter error, I would be okay with just adding the prop to the
example
section.Like as follows:
@MrArnoldPalmer wdyt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll fix it as commented.