Revert "chore(core): allow the bundler to re-use pre-existing bundler output (#8916)"

[eladb]

This logic to reuse bundler output is faulty. Once an asset is bundled, the bundle directory is moved into the cloud assembly (cdk.out) and therefore the logic that attempts to reuse the bundle directory only materializes in the case where moveSync decides to copy the directory and not just move it.

@jogold @misterjoshua please revisit.

This reverts commit 31d6e65.

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[mergify]

Title does not follow the guidelines of Conventional Commits. Please adjust title before merge.

[nija-at]

Please ensure that 'Revert' is not picked up by our bump script into our changelog.

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
• Commit ID: c418fc9
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[jogold]

Once an asset is bundled, the bundle directory is moved into the cloud assembly (cdk.out) and therefore the logic that attempts to reuse the bundle directory only materializes in the case where moveSync decides to copy the directory and not just move it.

Agree, but it still covers the case described in @misterjoshua's issue? Re-using assets during a synth/deploy not between synths/deploys (shown to be working in the following test https://github.com/aws/aws-cdk/pull/8916/files#diff-f22402543bd7a255f41d5bf7d711a835R152)

This is a problem for me when assets are slow to bundle and when there are several stacks (say, one per deployment environment) in a single app.

[eladb]

Agree, but it still covers the case described in @misterjoshua's issue? Re-using assets during a synth/deploy not between synths/deploys (shown to be working in the following test https://github.com/aws/aws-cdk/pull/8916/files#diff-f22402543bd7a255f41d5bf7d711a835R152)

Okay, I am now realizing that I missed some context. We are in the process of completely deprecating prepare() and synthesize(). As part of this effort, I've changed the way asset staging works such that it will stage the asset during initialization.

[eladb]

This means that this optimization no longer holds because the fs.moveSync happens before the constructor finishes.

[jogold]

OK, this is #8962 I presume? Will have look.

[eladb]

Yes.