fix(eks): Helm chart timeout expects duration #8773
Conversation
|
Is there a way to have a unit test for the python EKS custom resources? |
|
Not sure if it's related to this issue but I kept hitting lambda timeout when I deploy the integ.eks-cluster.ts. @eduardomourar did you hit this error?
|
|
Hi @eladb Looks like we have to first get this PR sorted before I can successfully build my integ test and continue my PRs. |
| cluster.addChart('dashboard', { chart: 'kubernetes-dashboard', repository: 'https://kubernetes-charts.storage.googleapis.com' }); | ||
| cluster.addChart('nginx-ingress', { chart: 'nginx-ingress', repository: 'https://helm.nginx.com/stable', namespace: 'kube-system' }); | ||
| cluster.addChart('nginx-ingress', { | ||
| chart: 'nginx-ingress', |
There was a problem hiding this comment.
Expecting to see an integ test update
There was a problem hiding this comment.
yes, i am update the integ test to check the logic for the both wait and timeout
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
No, I did not. But this looks like a error coming from the fact that we are actually running all those helm charts with wait set to true (because there is a bug even if you set to false). |
This resolves a problem with timeout parameter being passed down to Helm. The Helm version used (v3) expects a duration (in our case, in seconds such as
600s) instead of integer.fixes #8718
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license