Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(pkglint): ignore cdk.out and .cdk.staging #8709

Merged
merged 5 commits into from
Jun 28, 2020

Conversation

jogold
Copy link
Contributor

@jogold jogold commented Jun 24, 2020

Those directories can contain package.json files coming for bundled
assets (integ tests) that should never be linted.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

jogold and others added 2 commits June 24, 2020 14:08
Those directories can contain `package.json` files coming for bundled
assets that should never be linted.
eladb
eladb previously approved these changes Jun 25, 2020
@mergify mergify bot dismissed eladb’s stale review June 25, 2020 06:40

Pull request has been modified.

@mergify
Copy link
Contributor

mergify bot commented Jun 28, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 743e098
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Jun 28, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 991024d into aws:master Jun 28, 2020
@jogold jogold deleted the pkglint-ignores branch June 29, 2020 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants