fix(eks): fargate profile role not added to aws-auth by the cdk #8447
Conversation
When a Fargate Profile is added to the cluster, we need to make sure the aws-auth config map is updated from within the CDK app. EKS will do that behind the scenes if it's not done manually, but this means that it would be an out-of-band update of the config map and will be overridden by the CDK if the config map is updated manually. Fixes #7981 BREAKING CHANGE: `cluster.awsAuth` can now return `undefined` if the cluster is not kubectl-enabled. This ensures that users take into account the fact that the cluster may not support aws-auth updates. In most cases, it's sufficient to just use this syntax `cluster.awsAuth?.addxxx` to conditionally update aws-auth.
eladb
changed the title
Yes. I reverted this change. Updated description. |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
When a Fargate Profile is added to the cluster, we need to make sure the aws-auth config map is updated from within the CDK app. EKS will do that behind the scenes if it's not done manually, but this means that it would be an out-of-band update of the config map and will be overridden by the CDK if the config map is updated manually.
Fixes #7981
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license