-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(eks): support EKS service link role #7637
Conversation
Title does not follow the guidelines of Conventional Commits. Please adjust title before merge. |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
@pahud this seems like it's mainly about removing |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
@pahud Can you include some details in the commit message about how this change resolves the issue? |
OK. Done. |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
After this change it's impossible to update EKS clusters ( from AWS console or CDK ) deployed before 16th of April because the update requires the AmazonEKSServicePolicy in cluster IAM role. AWS returns an error:
To make it work the policy has to be added manually to the IAM role or the cluster has to be deployed from scratch. Unfortunately it causes a drift in cloudformation templates generated by CDK. |
Commit Message
core(eks): support EKS service link role
Prior to April 16, 2020,
AmazonEKSServicePolicy
was required for EKS cluster IAM role. With the newAWSServiceRoleForAmazonEKS
service-linked role, that policy is no longer required.This PR removes the
AmazonEKSServicePolicy
from the cluster role.Closes #7634
End Commit Message
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license