fix(efs): support tagging + filesystem naming

[michaelmoussa]

Commit Message

fix(efs): support tagging + filesystem naming

As is the case with Cognito User Pools, EFS filesystems do not use the property name Tags for tagging. The property name is FileSystemTags; however, there's an additional level of complexity due to the FileSystemTags being an array of ElasticFileSystemTag objects (which are just objects that enforce the {Key: "...", Value: "..."} convention.

This makes EFS filesystems taggable, adds an optional fileSystemName prop that gets set as the Name tag, and will also automatically give the filesystem a name if none is provided.

End Commit Message

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[michaelmoussa]

The regex below reveals a few other similar cases that would be worth exploring. I wrote the regex to basically find all Tags, excluding simply "Tags" and the few obvious ones that have already been addressed, so there are a lot of false positives, but stuff like RecoveryPointTags and HealthCheckTags, etc., are almost surely special cases like FileSystemTags and UserPoolTags.

$ grep -P '("[^"]+Tags"|"Tags[^"]+")(?<!"TagsEntry")(?<!"FileSystemTags")(?<!"UserPoolTags")' packages/@aws-cdk/cfnspec/spec/specification.json
1460:    "AWS::AppConfig::Application.Tags": {
1477:    "AWS::AppConfig::ConfigurationProfile.Tags": {
1511:    "AWS::AppConfig::Deployment.Tags": {
1528:    "AWS::AppConfig::DeploymentStrategy.Tags": {
1562:    "AWS::AppConfig::Environment.Tags": {
3008:    "AWS::AppSync::GraphQLApi.Tags": {
3418:    "AWS::Athena::WorkGroup.Tags": {
4260:        "RecoveryPointTags": {
4335:        "ListOfTags": {
6177:    "AWS::CloudWatch::InsightRule.Tags": {
8746:        "CopyTags": {
8842:        "TargetTags": {
8877:        "CopyTags": {
8914:        "TagsToAdd": {
8921:        "VariableTags": {
10852:    "AWS::EC2::LocalGatewayRouteTableVPCAssociation.Tags": {
25727:    "AWS::PinpointEmail::ConfigurationSet.Tags": {
25871:    "AWS::PinpointEmail::DedicatedIpPool.Tags": {
25905:    "AWS::PinpointEmail::Identity.Tags": {
35973:        "BackupPlanTags": {
36030:        "BackupVaultTags": {
39279:        "PipelineTags": {
42370:        "EnableECSManagedTags": {
42424:        "PropagateTags": {
44650:        "ExcludeResourceTags": {
44674:        "ResourceTags": {
46882:        "ResourceGroupTags": {
52448:        "HealthCheckTags": {
52473:        "HostedZoneTags": {

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
• Commit ID: 20dd3fc
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[rix0rrr]

Good find, thanks!

[mergify]

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
• Commit ID: e256253
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[mergify]

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[michaelmoussa]

Thanks for the quick merge!