Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(apigateway): auto-create RequestValidator from options to addMethod() #6780

Merged
merged 39 commits into from
Apr 1, 2020
Merged

feat(apigateway): auto-create RequestValidator from options to addMethod() #6780

merged 39 commits into from
Apr 1, 2020

Conversation

nirvana124
Copy link
Contributor

@nirvana124 nirvana124 commented Mar 18, 2020 •
edited by nija-at
Loading

Commit Message

feat(apigateway): auto-create RequestValidator from options to addMethod() (#6780)

closes #6193

End Commit Message

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

pankajy93 and others added 23 commits February 28, 2020 18:08
@pankajy93
fix(apigateway): Allows configuring authorization scopes in apigatewa…
375a157 
…y method fixes#6390
@pankajy93
Fixes build failure for Case sensitive fields
37249b2
@nirvana124
Merge branch 'master' into master
bab8d99
@nirvana124 @nija-at
Update packages/@aws-cdk/aws-apigateway/lib/method.ts
71ab433 
Co-Authored-By: Niranjan Jayakar <[email protected]>
@nirvana124 @nija-at
Update packages/@aws-cdk/aws-apigateway/lib/method.ts
26c31ea 
Co-Authored-By: Niranjan Jayakar <[email protected]>
@nirvana124 @nija-at
Update packages/@aws-cdk/aws-apigateway/lib/method.ts
14dfbe7 
Co-Authored-By: Niranjan Jayakar <[email protected]>
@nirvana124 @nija-at
Update packages/@aws-cdk/aws-apigateway/test/test.method.ts
4612c83 
Co-Authored-By: Niranjan Jayakar <[email protected]>
@nirvana124 @nija-at
Update packages/@aws-cdk/aws-apigateway/test/test.method.ts
87cbb71 
Co-Authored-By: Niranjan Jayakar <[email protected]>
@nirvana124
Merge branch 'master' into master
07a3188
@pankajy93
Added test cases to cover auth scopes absent and method options auth …
49d3752 
…scope take the priority in case method options and default options are passed
@pankajy93
Updating readme for authorizationScopes
3399253
@pankajy93
removing trailing white space to fix @aws-cdk/aws-apigateway: ERROR: …
913df38 
…/codebuild/output/src052287507/src/github.com/aws/aws-cdk/packages/@aws-cdk/aws-apigateway/lib/method.ts:80:87 - trailing whitespace
@nirvana124
Merge branch 'master' into master
3f451f7
@nirvana124
Merge branch 'master' into master
9b558f4
@pankajy93
adds comments under default integration and method section.
6b3e232
@nirvana124
Merge branch 'master' into master
7518e33
adjust lang in README
5cea74b
@pankajy93
Reolved conflicts
4660a32
@pankajy93
Merge branch 'master' of https://github.com/nirvana124/aws-cdk
c11dc30
@pankajy93
Merge branch 'master' of https://github.com/aws/aws-cdk
3f75fca
@pankajy93
Merge branch 'master' of https://github.com/aws/aws-cdk
b7b169e 
merge
@pankajy93
Merge branch 'master' of https://github.com/aws/aws-cdk
0399ffc
@pankajy93
feat(apigateway): configure RequestValidatorOptions instead of passin…
4f31455 
…g RequestValidator object in addMedthod fixes aws#6193
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 4f31455
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 953fea7
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 25d5fa0
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: ea3547c
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot dismissed nija-at’s stale review April 1, 2020 03:57

Pull request has been modified.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 3028e2e
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

nija-at
nija-at previously requested changes Apr 1, 2020
View reviewed changes
Copy link
Contributor

@nija-at nija-at left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about the delayed reply. There was a bit of a confusion with our bot and it didn't correctly dismiss my previous review. Should be all good going forward.

Mostly looks good. Just a few things to touch up.

packages/@aws-cdk/aws-apigateway/README.md Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-apigateway/test/test.method.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-apigateway/test/test.method.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-apigateway/test/test.method.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-apigateway/test/test.method.ts Outdated Show resolved Hide resolved
@mergify mergify bot dismissed nija-at’s stale review April 1, 2020 08:51

Pull request has been modified.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 265d8c5
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 38b5a5c
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 33cd0ec
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 4ed59a7
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

nija-at
nija-at previously approved these changes Apr 1, 2020
View reviewed changes
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 33cd0ec
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 27b06ef
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 1e0567d
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot dismissed nija-at’s stale review April 1, 2020 10:14

Pull request has been modified.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 5868367
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@nirvana124 nirvana124 requested a review from nija-at April 1, 2020 11:14
@nirvana124
Copy link
Contributor Author

@nija-at Sorry i merged the master into my branch after your approval. Bot dismissed your approval.
Can you please approve it again.

@mergify
Copy link
Contributor

mergify bot commented Apr 1, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 573464d into aws:master Apr 1, 2020
@nirvana124 nirvana124 deleted the nirvana124/requestValidator branch June 9, 2020 03:18
@nirvana124 nirvana124 restored the nirvana124/requestValidator branch June 9, 2020 03:19
@nirvana124 nirvana124 deleted the nirvana124/requestValidator branch June 9, 2020 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nija-at nija-at nija-at approved these changes

Assignees

@nija-at nija-at

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RequestValidator shouldn't require (or even expect) a restApi property.
4 participants
@nirvana124 @aws-cdk-automation @nija-at @pankajy93