Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(batch): computeEnvironments is now required for JobQueue #6616

Merged
merged 2 commits into from
Mar 9, 2020
Merged

fix(batch): computeEnvironments is now required for JobQueue #6616

merged 2 commits into from
Mar 9, 2020

Conversation

andrestone
Copy link
Contributor

@andrestone andrestone commented Mar 7, 2020 •
edited by iliapolo
Loading

Commit Message

fix(batch): computeEnvironments is now required for JobQueue (#6616)

Fixes: #6615

BREAKING CHANGE: computeEnvironments is now required

End Commit Message

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@andrestone andrestone force-pushed the fix-aws-batch-job-queue branch from 0d7b4a3 to 9e2353a Compare March 7, 2020 11:33
@andrestone andrestone force-pushed the fix-aws-batch-job-queue branch from 9e2353a to 7f79967 Compare March 7, 2020 11:51
ayush987goyal
ayush987goyal approved these changes Mar 7, 2020
View reviewed changes
Copy link
Contributor

@ayush987goyal ayush987goyal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 0d7b4a3
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 9e2353a
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 7f79967
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

iliapolo
iliapolo previously requested changes Mar 7, 2020
View reviewed changes
Copy link
Contributor

@iliapolo iliapolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to also add the "BREAKING CHANGE" notice. Either in the squash commit message or in the PR description like here.

packages/@aws-cdk/aws-batch/lib/job-queue.ts Outdated Show resolved Hide resolved
@andrestone andrestone force-pushed the fix-aws-batch-job-queue branch from 7f79967 to fec942f Compare March 8, 2020 12:00
@mergify mergify bot dismissed iliapolo’s stale review March 8, 2020 12:01

Pull request has been modified.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: fec942f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

iliapolo
iliapolo requested changes Mar 8, 2020
View reviewed changes
Copy link
Contributor

@iliapolo iliapolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrestone Since the "BREAKING CHANGE" is in the PR description, it should be formulated properly correctly so that mergify will extract the commit message.

That is:

Commit Message

computeEnvironments is now required for JobQueue (#6616)

Fixes: #6615

BREAKING CHANGE: computeEnvironments is now required

End Commit Message

@andrestone
Copy link
Contributor Author

Done, I guess! :D

@iliapolo
Copy link
Contributor

iliapolo commented Mar 9, 2020

Done, I guess! :D

Almost :) did the final thouchups

Thanks!

@mergify
Copy link
Contributor

mergify bot commented Mar 9, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 37d9592
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Mar 9, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 0b6c865 into aws:master Mar 9, 2020
eladb pushed a commit that referenced this pull request Mar 9, 2020
@andrestone
fix(batch): computeEnvironments is now required for JobQueue (#6616)
8f56b43 
Fixes: #6615

BREAKING CHANGE: `computeEnvironments` is now required
horsmand pushed a commit to horsmand/aws-cdk that referenced this pull request Mar 9, 2020
@andrestone @horsmand
fix(batch): computeEnvironments is now required for JobQueue (aws#6616
50d049d 
)

Fixes: aws#6615

BREAKING CHANGE: `computeEnvironments` is now required
@snyk-bot snyk-bot mentioned this pull request Apr 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ayush987goyal ayush987goyal ayush987goyal approved these changes

@iliapolo iliapolo iliapolo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AWS Batch JobQueue does not provide computeResources required for managed ComputeEnvironment
4 participants
@andrestone @aws-cdk-automation @iliapolo @ayush987goyal