feat(custom-resources): physical resource id union type #6518

iliapolo · 2020-02-29T18:34:55Z

Use a PhysicalResourceId union type instead of two string based discrete options.

Relates to #5873

BREAKING CHANGE: physicalResourceId and physicalResourceIdPath were unified to a concrete type under the physicalResourceId property. Use PhysicalResourceId.fromResponse and PhysicalResourceId.of factory functions to specify it.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

…resource-id-union

aws-cdk-automation · 2020-02-29T18:53:37Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
Commit ID: 29f25e6
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2020-02-29T19:02:48Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
Commit ID: 335cfd9
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

jogold

the different events defined aws-custom-resource-provider.test should be adapted to match the new structure of ResourceProperties.

packages/@aws-cdk/custom-resources/lib/aws-custom-resource/aws-custom-resource.ts

packages/@aws-cdk/custom-resources/lib/aws-custom-resource/runtime/index.ts

packages/@aws-cdk/custom-resources/test/aws-custom-resource/aws-custom-resource.test.ts

packages/@aws-cdk/custom-resources/lib/aws-custom-resource/aws-custom-resource.ts

aws-cdk-automation · 2020-03-01T09:00:11Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
Commit ID: d6c89b9
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2020-03-01T09:01:35Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
Commit ID: 375c0b9
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2020-03-01T09:06:02Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
Commit ID: aa83838
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2020-03-01T13:42:15Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
Commit ID: de46d71
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

packages/@aws-cdk/custom-resources/lib/aws-custom-resource/aws-custom-resource.ts

mergify · 2020-03-01T13:56:35Z

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Co-Authored-By: Elad Ben-Israel <[email protected]>

aws-cdk-automation · 2020-03-01T14:49:33Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
Commit ID: 63b07c8
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2020-03-01T14:55:50Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
Commit ID: b5443c1
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2020-03-01T14:58:24Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
Commit ID: d5fea64
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2020-03-01T15:06:52Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
Commit ID: 335029f
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mergify · 2020-03-01T15:28:59Z

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify · 2020-03-01T15:29:03Z

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

* added additional stack to 'ls' test so it doesn't fail * combine physicalResourceId and physicalResourceIdPath to a union type * fix tests according to new api * added doc strings and rename argument * fix tests * fixing some tests * enhance 'fromResponsePath' docstring * fix references to physicalResourceId in README * fix integ expected template and rename fromResponsePath to fromResponse * Rephrase docstring for `fromResponse` Co-Authored-By: Elad Ben-Israel <[email protected]> * Rephrase docstring for `of` Co-Authored-By: Elad Ben-Israel <[email protected]> * fix README reference to fromResponsePath Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Elad Ben-Israel <[email protected]>

Bumps [axios](https://github.com/axios/axios) from 1.7.2 to 1.7.4. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/axios/axios/releases">axios's releases</a>.</em></p> <blockquote> <h2>Release v1.7.4</h2> <h2>Release notes:</h2> <h3>Bug Fixes</h3> <ul> <li><strong>sec:</strong> CVE-2024-39338 (<a href="https://redirect.github.com/axios/axios/issues/6539">#6539</a>) (<a href="https://redirect.github.com/axios/axios/issues/6543">#6543</a>) (<a href="https://github.com/axios/axios/commit/6b6b605eaf73852fb2dae033f1e786155959de3a">6b6b605</a>)</li> <li><strong>sec:</strong> disregard protocol-relative URL to remediate SSRF (<a href="https://redirect.github.com/axios/axios/issues/6539">#6539</a>) (<a href="https://github.com/axios/axios/commit/07a661a2a6b9092c4aa640dcc7f724ec5e65bdda">07a661a</a>)</li> </ul> <h3>Contributors to this release</h3> <ul> <li> <a href="https://github.com/levpachmanov" title="+47/-11 ([#6543](axios/axios#6543) )">Lev Pachmanov</a></li> <li> <a href="https://github.com/hainenber" title="+49/-4 ([#6539](axios/axios#6539) )">Đỗ Trọng Hải</a></li> </ul> <h2>Release v1.7.3</h2> <h2>Release notes:</h2> <h3>Bug Fixes</h3> <ul> <li><strong>adapter:</strong> fix progress event emitting; (<a href="https://redirect.github.com/axios/axios/issues/6518">#6518</a>) (<a href="https://github.com/axios/axios/commit/e3c76fc9bdd03aa4d98afaf211df943e2031453f">e3c76fc</a>)</li> <li><strong>fetch:</strong> fix withCredentials request config (<a href="https://redirect.github.com/axios/axios/issues/6505">#6505</a>) (<a href="https://github.com/axios/axios/commit/85d4d0ea0aae91082f04e303dec46510d1b4e787">85d4d0e</a>)</li> <li><strong>xhr:</strong> return original config on errors from XHR adapter (<a href="https://redirect.github.com/axios/axios/issues/6515">#6515</a>) (<a href="https://github.com/axios/axios/commit/8966ee7ea62ecbd6cfb39a905939bcdab5cf6388">8966ee7</a>)</li> </ul> <h3>Contributors to this release</h3> <ul> <li> <a href="https://github.com/DigitalBrainJS" title="+211/-159 ([#6518](axios/axios#6518) [#6519](axios/axios#6519) )">Dmitriy Mozgovoy</a></li> <li> <a href="https://github.com/ValeraS" title="+3/-3 ([#6515](axios/axios#6515) )">Valerii Sidorenko</a></li> <li> <a href="https://github.com/prianyu" title="+2/-2 ([#6505](axios/axios#6505) )">prianYu</a></li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/axios/axios/blob/v1.x/CHANGELOG.md">axios's changelog</a>.</em></p> <blockquote> <h2><a href="https://github.com/axios/axios/compare/v1.7.3...v1.7.4">1.7.4</a> (2024-08-13)</h2> <h3>Bug Fixes</h3> <ul> <li><strong>sec:</strong> CVE-2024-39338 (<a href="https://redirect.github.com/axios/axios/issues/6539">#6539</a>) (<a href="https://redirect.github.com/axios/axios/issues/6543">#6543</a>) (<a href="https://github.com/axios/axios/commit/6b6b605eaf73852fb2dae033f1e786155959de3a">6b6b605</a>)</li> <li><strong>sec:</strong> disregard protocol-relative URL to remediate SSRF (<a href="https://redirect.github.com/axios/axios/issues/6539">#6539</a>) (<a href="https://github.com/axios/axios/commit/07a661a2a6b9092c4aa640dcc7f724ec5e65bdda">07a661a</a>)</li> </ul> <h3>Contributors to this release</h3> <ul> <li> <a href="https://github.com/levpachmanov" title="+47/-11 ([#6543](axios/axios#6543) )">Lev Pachmanov</a></li> <li> <a href="https://github.com/hainenber" title="+49/-4 ([#6539](axios/axios#6539) )">Đỗ Trọng Hải</a></li> </ul> <h2><a href="https://github.com/axios/axios/compare/v1.7.2...v1.7.3">1.7.3</a> (2024-08-01)</h2> <h3>Bug Fixes</h3> <ul> <li><strong>adapter:</strong> fix progress event emitting; (<a href="https://redirect.github.com/axios/axios/issues/6518">#6518</a>) (<a href="https://github.com/axios/axios/commit/e3c76fc9bdd03aa4d98afaf211df943e2031453f">e3c76fc</a>)</li> <li><strong>fetch:</strong> fix withCredentials request config (<a href="https://redirect.github.com/axios/axios/issues/6505">#6505</a>) (<a href="https://github.com/axios/axios/commit/85d4d0ea0aae91082f04e303dec46510d1b4e787">85d4d0e</a>)</li> <li><strong>xhr:</strong> return original config on errors from XHR adapter (<a href="https://redirect.github.com/axios/axios/issues/6515">#6515</a>) (<a href="https://github.com/axios/axios/commit/8966ee7ea62ecbd6cfb39a905939bcdab5cf6388">8966ee7</a>)</li> </ul> <h3>Contributors to this release</h3> <ul> <li> <a href="https://github.com/DigitalBrainJS" title="+211/-159 ([#6518](axios/axios#6518) [#6519](axios/axios#6519) )">Dmitriy Mozgovoy</a></li> <li> <a href="https://github.com/ValeraS" title="+3/-3 ([#6515](axios/axios#6515) )">Valerii Sidorenko</a></li> <li> <a href="https://github.com/prianyu" title="+2/-2 ([#6505](axios/axios#6505) )">prianYu</a></li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/axios/axios/commit/abd24a7367726616e60dfc04cb394b4be37cf597"><code>abd24a7</code></a> chore(release): v1.7.4 (<a href="https://redirect.github.com/axios/axios/issues/6544">#6544</a>)</li> <li><a href="https://github.com/axios/axios/commit/6b6b605eaf73852fb2dae033f1e786155959de3a"><code>6b6b605</code></a> fix(sec): CVE-2024-39338 (<a href="https://redirect.github.com/axios/axios/issues/6539">#6539</a>) (<a href="https://redirect.github.com/axios/axios/issues/6543">#6543</a>)</li> <li><a href="https://github.com/axios/axios/commit/07a661a2a6b9092c4aa640dcc7f724ec5e65bdda"><code>07a661a</code></a> fix(sec): disregard protocol-relative URL to remediate SSRF (<a href="https://redirect.github.com/axios/axios/issues/6539">#6539</a>)</li> <li><a href="https://github.com/axios/axios/commit/c6cce43cd94489f655f4488c5a50ecaf781c94f2"><code>c6cce43</code></a> chore(release): v1.7.3 (<a href="https://redirect.github.com/axios/axios/issues/6521">#6521</a>)</li> <li><a href="https://github.com/axios/axios/commit/e3c76fc9bdd03aa4d98afaf211df943e2031453f"><code>e3c76fc</code></a> fix(adapter): fix progress event emitting; (<a href="https://redirect.github.com/axios/axios/issues/6518">#6518</a>)</li> <li><a href="https://github.com/axios/axios/commit/85d4d0ea0aae91082f04e303dec46510d1b4e787"><code>85d4d0e</code></a> fix(fetch): fix withCredentials request config (<a href="https://redirect.github.com/axios/axios/issues/6505">#6505</a>)</li> <li><a href="https://github.com/axios/axios/commit/92cd8ed94362f929d3d0ed85ca84296c0ac8fd6d"><code>92cd8ed</code></a> chore(github): update ISSUE_TEMPLATE.md (<a href="https://redirect.github.com/axios/axios/issues/6519">#6519</a>)</li> <li><a href="https://github.com/axios/axios/commit/8966ee7ea62ecbd6cfb39a905939bcdab5cf6388"><code>8966ee7</code></a> fix(xhr): return original config on errors from XHR adapter (<a href="https://redirect.github.com/axios/axios/issues/6515">#6515</a>)</li> <li>See full diff in <a href="https://github.com/axios/axios/compare/v1.7.2...v1.7.4">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=axios&package-manager=npm_and_yarn&previous-version=1.7.2&new-version=1.7.4)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/aws/aws-cdk/network/alerts). </details>

iliapolo added 7 commits February 25, 2020 16:46

added additional stack to 'ls' test so it doesn't fail

bfe8e7c

Merge branch 'master' of github.com:aws/aws-cdk

00fe05c

Merge branch 'master' of github.com:aws/aws-cdk

f5bdb4b

combine physicalResourceId and physicalResourceIdPath to a union type

52a76ed

Merge branch 'master' of github.com:aws/aws-cdk into epolon/physical-…

19097b1

…resource-id-union

fix tests according to new api

6ec4d50

added doc strings and rename argument

29f25e6

mergify bot added the contribution/core This is a PR that came from AWS. label Feb 29, 2020

fix tests

335cfd9

iliapolo requested a review from eladb February 29, 2020 18:49

jogold reviewed Feb 29, 2020

View reviewed changes

eladb reviewed Mar 1, 2020

View reviewed changes

packages/@aws-cdk/custom-resources/lib/aws-custom-resource/aws-custom-resource.ts Outdated Show resolved Hide resolved

eladb reviewed Mar 1, 2020

View reviewed changes

packages/@aws-cdk/custom-resources/lib/aws-custom-resource/aws-custom-resource.ts Outdated Show resolved Hide resolved

iliapolo changed the title ~~chore(custom-resources): physical resource id union type~~ feat(custom-resources): physical resource id union type Mar 1, 2020

iliapolo added 3 commits March 1, 2020 10:35

fixing some tests

d6c89b9

enhance 'fromResponsePath' docstring

375c0b9

fix references to physicalResourceId in README

aa83838

iliapolo mentioned this pull request Mar 1, 2020

Graduate @aws-cdk/custom-resources to stable #5873

Closed

fix integ expected template and rename fromResponsePath to fromResponse

de46d71

iliapolo requested a review from eladb March 1, 2020 13:26

eladb reviewed Mar 1, 2020

View reviewed changes

packages/@aws-cdk/custom-resources/lib/aws-custom-resource/aws-custom-resource.ts Outdated Show resolved Hide resolved

eladb reviewed Mar 1, 2020

View reviewed changes

packages/@aws-cdk/custom-resources/lib/aws-custom-resource/aws-custom-resource.ts Outdated Show resolved Hide resolved

eladb approved these changes Mar 1, 2020

View reviewed changes

mergify bot and others added 4 commits March 1, 2020 13:57

Merge branch 'master' into epolon/physical-resource-id-union

63b07c8

Rephrase docstring for fromResponse

335029f

Co-Authored-By: Elad Ben-Israel <[email protected]>

Rephrase docstring for of

b5443c1

Co-Authored-By: Elad Ben-Israel <[email protected]>

fix README reference to fromResponsePath

d5fea64

iliapolo added the pr/do-not-merge This PR should not be merged at this time. label Mar 1, 2020

iliapolo removed the pr/do-not-merge This PR should not be merged at this time. label Mar 1, 2020

mergify bot merged commit d5000bc into master Mar 1, 2020

mergify bot deleted the epolon/physical-resource-id-union branch March 1, 2020 15:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(custom-resources): physical resource id union type #6518

feat(custom-resources): physical resource id union type #6518

iliapolo commented Feb 29, 2020 •

edited

Loading

aws-cdk-automation commented Feb 29, 2020

aws-cdk-automation commented Feb 29, 2020

jogold left a comment

aws-cdk-automation commented Mar 1, 2020

aws-cdk-automation commented Mar 1, 2020

aws-cdk-automation commented Mar 1, 2020

aws-cdk-automation commented Mar 1, 2020

mergify bot commented Mar 1, 2020

aws-cdk-automation commented Mar 1, 2020

aws-cdk-automation commented Mar 1, 2020

aws-cdk-automation commented Mar 1, 2020

aws-cdk-automation commented Mar 1, 2020

mergify bot commented Mar 1, 2020

mergify bot commented Mar 1, 2020

feat(custom-resources): physical resource id union type #6518

feat(custom-resources): physical resource id union type #6518

Conversation

iliapolo commented Feb 29, 2020 • edited Loading

aws-cdk-automation commented Feb 29, 2020

AWS CodeBuild CI Report

aws-cdk-automation commented Feb 29, 2020

AWS CodeBuild CI Report

jogold left a comment

Choose a reason for hiding this comment

aws-cdk-automation commented Mar 1, 2020

AWS CodeBuild CI Report

aws-cdk-automation commented Mar 1, 2020

AWS CodeBuild CI Report

aws-cdk-automation commented Mar 1, 2020

AWS CodeBuild CI Report

aws-cdk-automation commented Mar 1, 2020

AWS CodeBuild CI Report

mergify bot commented Mar 1, 2020

aws-cdk-automation commented Mar 1, 2020

AWS CodeBuild CI Report

aws-cdk-automation commented Mar 1, 2020

AWS CodeBuild CI Report

aws-cdk-automation commented Mar 1, 2020

AWS CodeBuild CI Report

aws-cdk-automation commented Mar 1, 2020

AWS CodeBuild CI Report

mergify bot commented Mar 1, 2020

mergify bot commented Mar 1, 2020

iliapolo commented Feb 29, 2020 •

edited

Loading