Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(applicationautoscaling): add PredefinedMetric for Lambda provisioned concurrency autoscaling #6394

Merged
merged 7 commits into from
Mar 28, 2020
Merged

feat(applicationautoscaling): add PredefinedMetric for Lambda provisioned concurrency autoscaling #6394

merged 7 commits into from
Mar 28, 2020

Conversation

pahud
Copy link
Contributor

@pahud pahud commented Feb 21, 2020 •
edited
Loading

Description

  • Add LAMBDA_PROVISIONED_CONCURRENCY_UTILIZATION in enum PredefinedMetric
  • Add example in README for AWS Lambda provisioned concurrency autoscaling

Commit Message

feat(applicationautoscaling): add PredefinedMetric for Lambda provisioned concurrency autoscaling (#6394 )

Closes #6369

End Commit Message

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: dfc6c9f
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 904022a
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 41fffff
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@pahud pahud requested a review from shivlaks February 21, 2020 10:22
@pahud pahud mentioned this pull request Feb 22, 2020
Closed
1 task
NetaNir
NetaNir previously requested changes Mar 9, 2020
View reviewed changes
Copy link
Contributor

@NetaNir NetaNir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the docs for all PredefinedMetric

The commit should be feat and not fix

packages/@aws-cdk/aws-applicationautoscaling/README.md Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-applicationautoscaling/lib/target-tracking-scaling-policy.ts Show resolved Hide resolved
@NetaNir NetaNir mentioned this pull request Mar 15, 2020
Closed
2 tasks
@mergify mergify bot dismissed NetaNir’s stale review March 18, 2020 03:02

Pull request has been modified.

@pahud pahud changed the title fix(applicationautoscaling): fix missing PredefinedMetric for Lambda … feat(applicationautoscaling): add PredefinedMetric for Lambda provisioned concurrency autoscaling Mar 18, 2020
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 3c86199
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 3c86199
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: fbeaa7b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 907cd94
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@pahud pahud requested a review from NetaNir March 18, 2020 04:35
@pahud
Copy link
Contributor Author

pahud commented Mar 18, 2020

Hi @NetaNir

All fixed. Please kindly review again. Thanks.

@mergify
Copy link
Contributor

mergify bot commented Mar 28, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: e8d3101
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Mar 28, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 45b68d5 into aws:master Mar 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NetaNir NetaNir NetaNir approved these changes

@shivlaks shivlaks Awaiting requested review from shivlaks

Assignees

@NetaNir NetaNir

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

applicationautoscaling: missing PredefinedMetric for Lambda provisioned concurrency
3 participants
@pahud @aws-cdk-automation @NetaNir