Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(route53): CaaAmazonRecord ignores recordName #6027

Merged
merged 3 commits into from
Feb 3, 2020

Conversation

jogold
Copy link
Contributor

@jogold jogold commented Jan 30, 2020

Fixes #5764


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

shivlaks
shivlaks previously approved these changes Feb 3, 2020
@mergify
Copy link
Contributor

mergify bot commented Feb 3, 2020

Thank you for contributing! Your pull request is now being automatically merged.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@jogold jogold requested a review from shivlaks February 3, 2020 20:16
@mergify mergify bot dismissed shivlaks’s stale review February 3, 2020 20:17

Pull request has been modified.

@jogold
Copy link
Contributor Author

jogold commented Feb 3, 2020

@shivlaks can you reapprove? There was a problem with yarn audit when mergify tried to merge.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@shivlaks
Copy link
Contributor

shivlaks commented Feb 3, 2020

@shivlaks can you reapprove? There was a problem with yarn audit when mergify tried to merge.

done

@mergify
Copy link
Contributor

mergify bot commented Feb 3, 2020

Thank you for contributing! Your pull request is now being automatically merged.

@mergify mergify bot merged commit 16f9721 into aws:master Feb 3, 2020
@jogold jogold deleted the route53-caa-record-name branch February 4, 2020 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

route53.CaaAmazonRecord ignores recordName prop
3 participants