fix(cli): wrongly assume aws config file always exists #6001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Duarte Nunes <[email protected]>
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
eladb
changed the title
eladb
reviewed
Feb 3, 2020
|
I just happen to notice it. I guess it depends on the behavior of the sdk, but I’d imagine it causes an enoent somewhere. |
eladb
changed the title
eladb
previously approved these changes
Feb 10, 2020
|
Thank you for contributing! Your pull request is now being automatically merged. |
1 similar comment
|
Thank you for contributing! Your pull request is now being automatically merged. |
|
The base fork belongs to an organization and can't be updated by maintainers (mergify in this case). I've created a mirror PR from a personal base here: #6196 |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Duarte Nunes [email protected]
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license