Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes in the documentation #533

Merged
merged 2 commits into from
Aug 9, 2018
Merged

Fixes in the documentation #533

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
705ddeb
Correct Java example in getting started
RomainMuller Aug 9, 2018
75cf4b7
Fix version-setting in the documentation build.
RomainMuller Aug 9, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/build-docs.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ echo "Generating reference docs toctree under ${refs_index}..."
cat ${refs_index}.template > ${refs_index}
ls -1 ${refdocsdir} | grep '.rst$' | sed -e 's/\.rst//' | sort | xargs -I{} echo " ${refdocs}/{}" >> ${refs_index}

export CDK_VERSION=$(cdk-version || echo "0.0.0.0")
export CDK_VERSION=$(../tools/pkgtools/bin/cdk-version)
echo "Set CDK_VERSION=${CDK_VERSION} (consumed by conf.py)..."

sphinx-build -b html $staging $output
2 changes: 1 addition & 1 deletion docs/src/getting-started.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -795,7 +795,7 @@ Configure the bucket to use KMS managed encryption:

new Bucket(this, "MyFirstBucket", BucketProps.builder()
.withVersioned(true)
.withEncryption("MANAGED")
.withEncryption(BucketEncryption.KmsManaged)
.build());

Compile the program:
Expand Down
4 changes: 2 additions & 2 deletions tools/pkgtools/bin/cdk-version
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
#!/bin/bash
cat ../../lerna.json | grep "version" | xargs | cut -d" " -f2
#!/usr/bin/env node
console.log(require('../../../lerna.json').version);