Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade to jsii 0.20.7 #5103

Merged
merged 8 commits into from
Nov 19, 2019
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
type a couple of more arrays
Elad Ben-Israel committed Nov 19, 2019
commit a8e2399e806244f47fccf73c58850bb1e1cca276
2 changes: 1 addition & 1 deletion packages/@aws-cdk/aws-ec2/lib/network-util.ts
Original file line number Diff line number Diff line change
@@ -69,7 +69,7 @@ export class NetworkUtils {
public static numToIp(ipNum: number): string {
// this all because bitwise math is signed
let remaining = ipNum;
const address = [];
const address = new Array<number>();
for (let i = 0; i < 4; i++) {
if (remaining !== 0) {
address.push(Math.floor(remaining / 256 ** (3 - i)));
2 changes: 1 addition & 1 deletion packages/@aws-cdk/aws-ec2/lib/vpc.ts
Original file line number Diff line number Diff line change
@@ -1661,7 +1661,7 @@ class CompositeDependable implements IDependable {
const self = this;
DependableTrait.implement(this, {
get dependencyRoots() {
const ret = [];
const ret = new Array<IConstruct>();
for (const dep of self.dependables) {
ret.push(...DependableTrait.get(dep).dependencyRoots);
}