Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use new parallel build feature of jsii #4367

Merged
merged 4 commits into from
Nov 1, 2019

Conversation

rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Oct 3, 2019

Improve build times by using the new "build-all-at-once" feature of
jsii-pacmak.

Goes together with aws/jsii#849.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Improve build times by using the new "build-all-at-once" feature of
jsii-pacmak.

Goes together with aws/jsii#849.
@rix0rrr rix0rrr requested review from RomainMuller and eladb October 3, 2019 16:48
@mergify
Copy link
Contributor

mergify bot commented Oct 3, 2019

Thanks so much for taking the time to contribute to the AWS CDK ❤️

We will shortly assign someone to review this pull request and help get it
merged. In the meantime, please take a minute to make sure you follow this
checklist
:

  • PR title type(scope): text
    • type: fix, feat, refactor go into CHANGELOG, chore is hidden
    • scope: name of module without aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
    • text: use all lower-case, do not end with a period, do not include issue refs
  • PR Description
    • Rationale: describe rationale of change and approach taken
    • Issues: indicate issues fixed via: fixes #xxx or closes #xxx
    • Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
  • Testing
    • Unit test added. Prefer to add a new test rather than modify existing tests
    • CLI or init templates change? Re-run/add CLI integration tests
  • Documentation
    • README: update module README to describe new features
    • API docs: public APIs must be documented. Copy from official AWS docs when possible
    • Design: for significant features, follow design process

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@rix0rrr
Copy link
Contributor Author

rix0rrr commented Oct 4, 2019

(Obviously this will not compile with the current jsii version)

@SomayaB SomayaB added the contribution/core This is a PR that came from AWS. label Oct 11, 2019
@rix0rrr rix0rrr added the pr/do-not-merge This PR should not be merged at this time. label Oct 31, 2019
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@rix0rrr
Copy link
Contributor Author

rix0rrr commented Nov 1, 2019

At the moment this PR brings the build time down from ~45mins to ~30mins. We should probably be parallelizing the checking of examples.

@rix0rrr rix0rrr merged commit 9fd88c9 into master Nov 1, 2019
@rix0rrr rix0rrr deleted the huijbers/parallel-build branch November 1, 2019 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. pr/do-not-merge This PR should not be merged at this time.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants