Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ecs): FargateTaskDefinition supports Tokens for cpu and memory #4224

Merged
merged 4 commits into from
Sep 26, 2019
Merged

fix(ecs): FargateTaskDefinition supports Tokens for cpu and memory #4224

merged 4 commits into from
Sep 26, 2019

Conversation

parisholley
Copy link
Contributor

It appears there are some inconsistencies with the API (some places wanting numbers, others want strings). Because of the manual casting to a string, Lazy.numberValue (or stringValue now with this change), would return erroneous numbers in the CF output.

Hard to gauge whether to consider this a fix or breaking change, issuing pull early as local build from master does not work for me.

@mergify
Copy link
Contributor

mergify bot commented Sep 24, 2019

Thanks so much for taking the time to contribute to the AWS CDK ❤️

We will shortly assign someone to review this pull request and help get it
merged. In the meantime, please take a minute to make sure you follow this
checklist:

  • PR title type(scope): text
    • type: fix, feat, refactor go into CHANGELOG, chore is hidden
    • scope: name of module without aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
    • text: use all lower-case, do not end with a period, do not include issue refs
  • PR Description
    • Rationale: describe rationale of change and approach taken
    • Issues: indicate issues fixed via: fixes #xxx or closes #xxx
    • Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
  • Testing
    • Unit test added. Prefer to add a new test rather than modify existing tests
    • CLI or init templates change? Re-run/add CLI integration tests
  • Documentation
    • README: update module README to describe new features
    • API docs: public APIs must be documented. Copy from official AWS docs when possible
    • Design: for significant features, follow design process

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@parisholley parisholley requested a review from eladb as a code owner September 25, 2019 01:30
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

rix0rrr
rix0rrr previously requested changes Sep 25, 2019
View reviewed changes
Copy link
Contributor

@rix0rrr rix0rrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say this is the wrong way to go about it.

The correct solution will be to use a function like here:

aws-cdk/packages/@aws-cdk/aws-autoscaling/lib/auto-scaling-group.ts

Line 1088 in 1180c1b

function stringifyNumber(x: number) {

@parisholley
Copy link
Contributor Author

@rix0rrr ah, i figured there was a pattern for doing that, but an example was hard to find. will update...

@mergify mergify bot dismissed rix0rrr’s stale review September 25, 2019 13:47

Pull request has been modified.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@rix0rrr
Copy link
Contributor

rix0rrr commented Sep 25, 2019

I see your commit message. Don't import stringifyNumber please, I would prefer you copy/pasted it.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@rix0rrr rix0rrr changed the title bug(ecs) FargateTaskDefinition does not support Lazy values fix(ecs): FargateTaskDefinition supports Tokens for cpu and memory Sep 26, 2019
@mergify
Copy link
Contributor

mergify bot commented Sep 26, 2019

Thank you for contributing! Your pull request is now being automatically merged.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit c9529f9 into aws:master Sep 26, 2019
alukach pushed a commit to alukach/aws-cdk that referenced this pull request Nov 1, 2019
@parisholley @alukach
fix(ecs): FargateTaskDefinition supports Tokens for cpu and memory (
295d82b 
aws#4224)

* support lazy values in fargate task definition

* reduce test case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rix0rrr rix0rrr rix0rrr approved these changes

@SoManyHs SoManyHs Awaiting requested review from SoManyHs

@eladb eladb Awaiting requested review from eladb

Assignees

@rix0rrr rix0rrr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@parisholley @aws-cdk-automation @rix0rrr