Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(elbv2): make load balancer targets bind to interfaces #4132

Merged
merged 4 commits into from
Sep 25, 2019
Merged

refactor(elbv2): make load balancer targets bind to interfaces #4132

merged 4 commits into from
Sep 25, 2019

Conversation

rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Sep 18, 2019

The attachToApplicationTargetGroup() (and similar for the NLB) methods
of the load balancer target interfaces took a concrete TargetGroup
class.

This deviates from established CDK standards, and prevents their use
with imported TargetGroups.

Bring the code in line with expectations.

Fixes #4121.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@rix0rrr
refactor(elbv2): make load balancer targets bind to interfaces
0bd808c 
The `attachToApplicationTargetGroup()` (and similar for the NLB) methods
of the load balancer target interfaces took a concrete TargetGroup
class.

This deviates from established CDK standards, and prevents their use
with imported TargetGroups.

Bring the code in line with expectations.

Fixes #4121.
@rix0rrr rix0rrr added the effort/small Small work item – less than a day of effort label Sep 18, 2019
@rix0rrr rix0rrr requested a review from a team September 18, 2019 13:56
@rix0rrr rix0rrr requested a review from SoManyHs as a code owner September 18, 2019 13:56
@rix0rrr rix0rrr self-assigned this Sep 18, 2019
@mergify
Copy link
Contributor

mergify bot commented Sep 18, 2019

Thanks so much for taking the time to contribute to the AWS CDK ❤️

We will shortly assign someone to review this pull request and help get it
merged. In the meantime, please take a minute to make sure you follow this
checklist:

  • PR title type(scope): text
    • type: fix, feat, refactor go into CHANGELOG, chore is hidden
    • scope: name of module without aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
    • text: use all lower-case, do not end with a period, do not include issue refs
  • PR Description
    • Rationale: describe rationale of change and approach taken
    • Issues: indicate issues fixed via: fixes #xxx or closes #xxx
    • Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
  • Testing
    • Unit test added. Prefer to add a new test rather than modify existing tests
    • CLI or init templates change? Re-run/add CLI integration tests
  • Documentation
    • README: update module README to describe new features
    • API docs: public APIs must be documented. Copy from official AWS docs when possible
    • Design: for significant features, follow design process

1 similar comment
@mergify
Copy link
Contributor

mergify bot commented Sep 18, 2019

Thanks so much for taking the time to contribute to the AWS CDK ❤️

We will shortly assign someone to review this pull request and help get it
merged. In the meantime, please take a minute to make sure you follow this
checklist:

  • PR title type(scope): text
    • type: fix, feat, refactor go into CHANGELOG, chore is hidden
    • scope: name of module without aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
    • text: use all lower-case, do not end with a period, do not include issue refs
  • PR Description
    • Rationale: describe rationale of change and approach taken
    • Issues: indicate issues fixed via: fixes #xxx or closes #xxx
    • Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
  • Testing
    • Unit test added. Prefer to add a new test rather than modify existing tests
    • CLI or init templates change? Re-run/add CLI integration tests
  • Documentation
    • README: update module README to describe new features
    • API docs: public APIs must be documented. Copy from official AWS docs when possible
    • Design: for significant features, follow design process

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@nija-at nija-at added the pr/do-not-merge This PR should not be merged at this time. label Sep 24, 2019
nija-at
nija-at approved these changes Sep 24, 2019
View reviewed changes
Copy link
Contributor

@nija-at nija-at left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Make sure you check to see if there are any subsequent operations after the attach... that attempts to mutate the attached group and would fail. The error messaging might need to be updated in these places.

packages/@aws-cdk/aws-autoscaling/lib/auto-scaling-group.ts
if (targetGroup instanceof elbv2.ApplicationTargetGroup) {
// Copy onto self if it's a concrete type. We need this for autoscaling
// based on request count, which we cannot do with an imported TargetGroup.
this.albTargetGroup = targetGroup;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix up the error messaging in the scaleOnRequestCount() method. There are now two conditions when this.albTargetGroup will be undefined.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@rix0rrr rix0rrr merged commit 1180c1b into master Sep 25, 2019
@rix0rrr rix0rrr deleted the huijbers/alb-iface branch September 25, 2019 13:07
@NGL321 NGL321 added the contribution/core This is a PR that came from AWS. label Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nija-at nija-at nija-at approved these changes

@SoManyHs SoManyHs Awaiting requested review from SoManyHs

@eladb eladb Awaiting requested review from eladb

@RomainMuller RomainMuller Awaiting requested review from RomainMuller

@shivlaks shivlaks Awaiting requested review from shivlaks

@skinny85 skinny85 Awaiting requested review from skinny85

Assignees

@rix0rrr rix0rrr

Labels
contribution/core This is a PR that came from AWS. effort/small Small work item – less than a day of effort pr/do-not-merge This PR should not be merged at this time.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

attachToApplicationTargetGroup should take an interface
4 participants
@rix0rrr @aws-cdk-automation @nija-at @NGL321