fix(apigateway): cross-stack lambda integration causes a cyclic reference

[nija-at]

1. Token resolution of Deployment construct must not resolve the entire
   stack, specifically during the prepare phase.

   stack.resolve() works only after the CDK app has been fully prepared.
   During the 'prepare' phase, token resolution should instead resolve
   the token partially and within the local context.

2. Scope the lambda.CfnPermission construct closer to the consumer of
   the permission rather than being closer to the lambda function.

   For instance, when a lambda function is being consumed by an
   APIGateway RestApi Method as a cross-stack reference, placing the
   lambda.CfnPermission construct closer to the RestApi Method reduces
   the possibility of cyclic dependencies.

fixes #3705, #3000

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[mergify]

Thanks so much for taking the time to contribute to the AWS CDK ❤️

We will shortly assign someone to review this pull request and help get it
merged. In the meantime, please take a minute to make sure you follow this
checklist:

• PR title type(scope): text
  • type: fix, feat, refactor go into CHANGELOG, chore is hidden
  • scope: name of module without aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
  • text: use all lower-case, do not end with a period, do not include issue refs
• PR Description
  • Rationale: describe rationale of change and approach taken
  • Issues: indicate issues fixed via: fixes #xxx or closes #xxx
  • Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
• Testing
  • Unit test added. Prefer to add a new test rather than modify existing tests
  • CLI or init templates change? Re-run/add CLI integration tests
• Documentation
  • README: update module README to describe new features
  • API docs: public APIs must be documented. Copy from official AWS docs when possible
  • Design: for significant features, follow design process

[mergify]

Continuous integration build failed

Pull request has been modified.

Pull request has been modified.

[eladb]

Make a couple of tweaks (with "@default" if there is concrete default value, we just use "-") and the title of a "fix" PR should describe the bug, not the fix. The changelog will show "fixes" and then a list of bugs that were fixed.

Pull request has been modified.

[ashwgupt]

Can someone please share the release version carrying this fix?

We are still seeing this issue when using v 1.10.0

[nija-at]

It was released in 1.9.0. You can usually find this information in our CHANGELOG.md.

Make sure your application is using CDK packages >=1.9.0 and not just a later CLI version (for typescript, by checking package-lock.json).

If you think this is still occurring, feel free to open a new issue with repro steps.

[wywarren]

Has this been resolved for python? We're seeing similar cyclic problems with API Gateway and Lambda being separated into two stacks and passing the reference of the API gateway into the Lambda stack.