Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(comments) Fix typo on a gitattributes comment #3978

Merged
merged 1 commit into from
Sep 6, 2019
Merged

chore(comments) Fix typo on a gitattributes comment #3978

merged 1 commit into from
Sep 6, 2019

Conversation

raphael-riel
Copy link
Contributor

Stumbled on a typo while satisfying my curiosity.
Hopefully, I'll suggest something a little more substantial next time 😄

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@mergify
Copy link
Contributor

mergify bot commented Sep 6, 2019

Pull Request Checklist

  • Testing
  • Unit test added (prefer to add a new test rather than modify existing tests)
  • CLI change? Re-run/add CLI integration tests
  • Documentation
  • Inline docs: make sure all public APIs are documented (copy & paste from official AWS docs)
  • README: update module README
  • Design: for significant features, follow the design process
  • Title uses the format type(scope): text
  • Type: fix, feat, refactor go into CHANGELOG, chore is hidden
  • Scope: name of the module without the aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
  • Style: use all lower-case, do not end with a period
  • Description
  • Rationale: describe rationale of change and approach taken
  • Issues: Indicate issues fixed via: fixes #xxx or closes #xxx
  • Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
  • Sensitive Modules (requires 2 PR approvers)
  • IAM document library (in @aws-cdk/aws-iam)
  • EC2 security groups and ACLs (in @aws-cdk/aws-ec2)
  • Grant APIs (if not based on official documentation with a reference)

@raphael-riel raphael-riel changed the title Fix typo on a gitattributes comment fix(comments) Typo on a gitattributes comment Sep 6, 2019
@raphael-riel raphael-riel changed the title fix(comments) Typo on a gitattributes comment chore(comments) Fix typo on a gitattributes comment Sep 6, 2019
Copy link
Contributor

@skinny85 skinny85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for the contribution! And don't worry, docs are important, it's super helpful to fix these small issues :). Thanks!

@skinny85 skinny85 merged commit 06a96ad into aws:master Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants