-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(lambda): environment var values are strings #3858
Conversation
AWS Lambda requires that all environment variables will be strings but the API indicated `any` as the type of the value. If users would pass in a non-string value, they would see an error only during deployment. Fixes #3337
Pull Request Checklist
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not breaking because non string values never worked right?
Codebuild (Continuous Integration) build failed for current commits. Please check log and resolve before PR is merged. |
1 similar comment
Codebuild (Continuous Integration) build failed for current commits. Please check log and resolve before PR is merged. |
Pull request has been modified.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't forget to list breaking changes in commit message.
@rix0rrr technically this can’t break anyone because non-string values never worked |
Codebuild (Continuous Integration) build failed for current commits. Please check log and resolve before PR is merged. |
Thank you for contributing! Your pull request is now being automatically merged. |
Thank you for contributing! Your pull request is now being automatically merged. |
Codebuild (Continuous Integration) build failed for current commits. Please check log and resolve before PR is merged. |
Thank you for contributing! Your pull request is now being automatically merged. |
Thanks so much for taking the time to contribute to the AWS CDK ❤️ We will shortly assign someone to review this pull request and help get it
|
AWS Lambda requires that all environment variables will be
strings but the API indicated
any
as the type of the value.If users would pass in a non-string value, they would see an
error only during deployment.
Fixes #3337
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license