Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ec2): add GenericWindowsImage #3454

Merged
merged 4 commits into from
Aug 7, 2019
Merged

feat(ec2): add GenericWindowsImage #3454

merged 4 commits into from
Aug 7, 2019

Conversation

slipdexic
Copy link
Contributor

@slipdexic slipdexic commented Jul 27, 2019

Adds support for non-default Windows AMIs.

Fixes #3400


Please read the contribution guidelines and follow the pull-request checklist.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

* Created new GenericWindowsImaeProps
* Created new Class GenericWindowsImage
@slipdexic
Copy link
Contributor Author

How do I get aws/aws-cdk-team to review?
@aws-cdk

@slipdexic slipdexic changed the title feat(ec2): Use custom Windows AMI (#3400) feat(ec2): use custom windows AMI (#3400) Jul 27, 2019
Copy link
Contributor

@eladb eladb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

Can you please add a unit test for this?
Also, please take another look at the contribution guidelines to make sure you didn't forget anything.

@NGL321 NGL321 assigned NGL321 and rix0rrr and unassigned NGL321 Aug 1, 2019
@skinny85 skinny85 changed the title feat(ec2): use custom windows AMI (#3400) feat(ec2): use custom windows AMI Aug 2, 2019
@rix0rrr rix0rrr changed the title feat(ec2): use custom windows AMI feat(ec2): add GenericWindowsImage Aug 7, 2019
@mergify mergify bot merged commit f4ca41c into aws:master Aug 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws-ec2 Missing support for EC2 Windows Custom Images
5 participants