feat(autoscaling): health check configuration (re-roll) #3436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements missing Auto Scaling Group properties [HealthCheckType](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-as-group.html#cfn-as-group-healthchecktype) and [HealthCheckGracePeriod](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-as-group.html#cfn-as-group-healthcheckgraceperiod) They are grouped in a `healthCheck` object property. The constructor checks that the following requirement is fulfilled: > If you are adding an ELB health check, you must specify this property. Fixes #3381
RomainMuller
added
the
pr/blocked
RomainMuller
changed the title
|
Romain, I'm passing this off to you as I don't have enough state on the release train of jsii, and I suspect you do. |
RomainMuller
removed
the
pr/blocked
|
I meant to get back to this today anyway... So yeah - the current release of JSII should be working with this correctly; and the dependencies of CDK were already upgraded with the latest release. This is ready to re-roll now! |
rix0rrr
approved these changes
Aug 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-introduce #3390, which was reverted as part of #3435 due to aws/jsii#650.
Please read the contribution guidelines and follow the pull-request checklist.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license