fix(aws-ecs-patterns): update ecs-patterns to be consistent across constructs #3404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@SoManyHs please review |
piradeepk
changed the title
SoManyHs
reviewed
Jul 24, 2019
packages/@aws-cdk/aws-ecs-patterns/lib/base/load-balanced-service-base.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/aws-ecs-patterns/lib/base/load-balanced-service-base.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/aws-ecs-patterns/lib/base/scheduled-task-base.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/aws-ecs-patterns/lib/base/scheduled-task-base.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/aws-ecs-patterns/lib/ecs/load-balanced-ecs-service.ts
Outdated
Show resolved
Hide resolved
piradeepk
changed the title
|
PR updated with feedback addressed |
piradeepk
force-pushed
the
normalizeEcsPatterns
branch
from
fbe120f to
0928442
Compare
NGL321
approved these changes
Jul 26, 2019
|
@pkandasamy91 this needs a bit of TLC |
piradeepk
force-pushed
the
normalizeEcsPatterns
branch
from
c055825 to
365a3a1
Compare
|
TLC provided! Rebased |
|
Thanks. Waiting for build to pass |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update ecs-patterns to be consistent across constructs
Please read the contribution guidelines and follow the pull-request checklist.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license