-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ecs): ECS optimized Windows images #3376
Merged
Merged
Changes from 7 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
eb63ce4
feat(ecs): support windows images
48780fb
fix(ecs): throw if both windowsVersion and generation props are set
47e81a6
fix(ecs): remove linux mention in windows hardware error
e3e5739
fix(ecs): fix windowsVersion assignation, update test
5c01a39
fix(ecs): windowsVersion test deepEqual
b1f003b
fix(ecs): test linux ami ssm parameter
a95a33f
Merge branch 'master' into feat-windows-ecs
f2a8e1d
Merge branch 'master' into feat-windows-ecs
0309b87
fix(ecs): remove duplicate core import
9bc06bf
fix(ecs): tslint
12d99eb
feat(ecs): EcsOptimizedAmi refactor, use static constructors
450b507
fix(ecs): remove unused interfaces
42bfb0b
fix(ecs): remove duplicate import
3cbeb5f
fix(ecs): fix property ordering
19e874d
fix(ecs): refactor EcsOptimizedImage
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally, the
generation
andwindowsVersion
properties would be merged, but I didn't think it was worth the refactoring and breaking change.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can @deprecate
generation
in favor ofamazonLinuxGeneration
(still supportgeneration
for backwards compat and in the next MV we will remove)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thoughts? Maybe in a subsequent PR? At least update #3398 with this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I didn't see your previous comment. I can add it to this PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we just replace it with an
image
union construct, to have the definition enforce the mutual exclusion?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So what's up with this? Didn't we say this is gone?