Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ecs): update driverOpts type definition from array to map #3358

Merged
merged 11 commits into from
Aug 9, 2019
6 changes: 6 additions & 0 deletions allowed-breaking-changes.txt
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
incompatible-argument:@aws-cdk/aws-ecs.Ec2TaskDefinition.<initializer>
incompatible-argument:@aws-cdk/aws-ecs.Ec2TaskDefinition.addVolume
incompatible-argument:@aws-cdk/aws-ecs.FargateTaskDefinition.<initializer>
incompatible-argument:@aws-cdk/aws-ecs.FargateTaskDefinition.addVolume
incompatible-argument:@aws-cdk/aws-ecs.TaskDefinition.<initializer>
incompatible-argument:@aws-cdk/aws-ecs.TaskDefinition.addVolume
change-return-type:@aws-cdk/core.Fn.getAtt
new-argument:@aws-cdk/aws-iam.ManagedPolicy.<initializer>
new-argument:@aws-cdk/aws-iam.ManagedPolicy.<initializer>
2 changes: 1 addition & 1 deletion packages/@aws-cdk/aws-ecs/lib/base/task-definition.ts
Original file line number Diff line number Diff line change
Expand Up @@ -484,7 +484,7 @@ export interface DockerVolumeConfiguration {
*
* @default No options
*/
readonly driverOpts?: string[];
readonly driverOpts?: {[key: string]: string};
/**
* Custom metadata to add to your Docker volume.
*
Expand Down
10 changes: 8 additions & 2 deletions packages/@aws-cdk/aws-ecs/test/ec2/test.ec2-task-definition.ts
Original file line number Diff line number Diff line change
Expand Up @@ -520,7 +520,10 @@ export = {
name: "scratch",
dockerVolumeConfiguration: {
driver: "local",
scope: ecs.Scope.TASK
scope: ecs.Scope.TASK,
driverOpts: {
key1: "value"
}
}
};

Expand All @@ -540,7 +543,10 @@ export = {
Name: "scratch",
DockerVolumeConfiguration: {
Driver: "local",
Scope: 'task'
Scope: 'task',
DriverOpts: {
key1: "value"
}
}
}]
}));
Expand Down