chore(toolkit): change bundling to not have a dependency on the aws-cdk package #32989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrgrain
added
pr/do-not-merge
mrgrain
force-pushed
the
mrgrain/chore/toolkit/do-not-depend-on-cli
branch
from
c2c7e5b to
d5c700c
Compare
mrgrain
changed the title
rix0rrr
approved these changes
Jan 17, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #32989 +/- ##
=======================================
Coverage 81.44% 81.44%
=======================================
Files 225 225
Lines 13702 13702
Branches 2404 2404
=======================================
Hits 11160 11160
Misses 2267 2267
Partials 275 275
Flags with carried forward coverage won't be shown. Click here to find out more.
|
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead use local file references.
We still have it listed as a dev dependency, because we do need the cli build in the monorepo before the toolkit.
Also adds a script to publish a "public" version locally
Describe any new or updated permissions being added
n/a
Description of how you validated changes
It builds and the "published" package can be used successfully
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license