fix(cli): allow credential plugins to return null for expiration
#32554
+11
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the type definitions, the `expiration` field of V3 AWS credentials must be `undefined` or `Date`, but we are running into situations in reality where the value is `null`, leading to the error: ``` TypeError: Cannot read properties of null (reading 'getTime') ``` Survive that specific case.
rix0rrr
added
the
pr-linter/cli-integ-tested
rix0rrr
added
pr-linter/exempt-integ-test
HBobertz
approved these changes
Dec 17, 2024
rix0rrr
requested a deployment
to
test-pipeline
GitHub Actions
Waiting
mrgrain
approved these changes
Dec 17, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #32554 +/- ##
=======================================
Coverage 78.85% 78.85%
=======================================
Files 108 108
Lines 7165 7165
Branches 1319 1319
=======================================
Hits 5650 5650
Misses 1330 1330
Partials 185 185
Flags with carried forward coverage won't be shown. Click here to find out more.
|
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the type definitions, the
expirationfield of V3 AWS credentials must beundefinedorDate, but we are running into situations in reality where the value isnull, leading to the error:Survive that specific case.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license