chore(cli-lib-alpha): slightly more idiomatic use of mocks #32512
Conversation
The original version of this code was failing for obscure reasons.
| import * as cli from 'aws-cdk/lib'; | ||
| import * as core from 'aws-cdk-lib'; |
There was a problem hiding this comment.
This is was importing aws-cdk-lib/core on purpose. Curios why it needs changing.
There was a problem hiding this comment.
Because this doesn't seem to work in the new monorepo, I assume because aws-cdk-lib has been bundled.
Why must it import the submodule directly?
There was a problem hiding this comment.
Because it is best practice to import submodules and if that's not working anymore in the new monorepo that is extremely concerning to me. Especially if we don't understand why it is not working anymore.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #32512 +/- ##
=======================================
Coverage 78.66% 78.66%
=======================================
Files 107 107
Lines 7161 7161
Branches 1320 1320
=======================================
Hits 5633 5633
Misses 1343 1343
Partials 185 185
Flags with carried forward coverage won't be shown. Click here to find out more.
|
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Comments on closed issues and PRs are hard for our team to see. |
The original version of this code was failing for obscure reasons.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license