chore(cdk-cli-wrapper): fix tests for monorepo #32511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In a slightly different testing setup, the `jest.spyOn` calls fail with the error: ``` Cannot redefine property: spawnSync ``` This has to do with how the object representing the `fs` module is defined. We can override the module and return a plain object with all the functions, so that the elements can be mocked later on.
mrgrain
approved these changes
Dec 13, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #32511 +/- ##
=======================================
Coverage 78.66% 78.66%
=======================================
Files 107 107
Lines 7161 7161
Branches 1320 1320
=======================================
Hits 5633 5633
Misses 1343 1343
Partials 185 185
Flags with carried forward coverage won't be shown. Click here to find out more.
|
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a slightly different testing setup, the
jest.spyOncalls fail with the error:This has to do with how the object representing the
fsmodule is defined. We can override the module and return a plain object with all the functions, so that the elements can be mocked later on.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license