Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(rds): add support for 8.0.mysql_aurora.3.04.3 #32399

Merged
merged 3 commits into from
Dec 10, 2024

Conversation

hiromu-ootsuka
Copy link
Contributor

@hiromu-ootsuka hiromu-ootsuka commented Dec 6, 2024

(description based on #30479)

Reason for this change

Add support for newly supported 8.0.mysql_aurora.3.04.3.
https://docs.aws.amazon.com/AmazonRDS/latest/AuroraMySQLReleaseNotes/AuroraMySQL.Updates.3043.html

Description of changes

Add a new version as a new property to AuroraMysqlEngineVersion class.

Description of how you validated changes

I used the AWS CLI to verify that the new version is available.

aws rds describe-db-engine-versions --engine aurora-mysql --query "DBEngineVersions[?EngineVersion=='8.0.mysql_aurora.3.04.3']"
[
    {
        "Engine": "aurora-mysql",
        "EngineVersion": "8.0.mysql_aurora.3.04.3",
        "DBParameterGroupFamily": "aurora-mysql8.0",
        "DBEngineDescription": "Aurora MySQL",
        "DBEngineVersionDescription": "Aurora MySQL 3.04.3 (compatible with MySQL 8.0.28)",
        "ValidUpgradeTarget": [
            {
                "Engine": "aurora-mysql",
                "EngineVersion": "8.0.mysql_aurora.3.06.1",
                "Description": "Aurora MySQL 3.06.1 (compatible with MySQL 8.0.34)",
                "AutoUpgrade": false,
                "IsMajorVersionUpgrade": false,
                "SupportedEngineModes": [
                    "provisioned"
                ],
                "SupportsParallelQuery": true,
                "SupportsGlobalDatabases": true,
                "SupportsBabelfish": false,
                "SupportsLocalWriteForwarding": true
            },
            {
                "Engine": "aurora-mysql",
                "EngineVersion": "8.0.mysql_aurora.3.07.1",
                "Description": "Aurora MySQL 3.07.1 (compatible with MySQL 8.0.36)",
                "AutoUpgrade": false,
                "IsMajorVersionUpgrade": false,
                "SupportedEngineModes": [
                    "provisioned"
                ],
                "SupportsParallelQuery": true,
                "SupportsGlobalDatabases": true,
                "SupportsBabelfish": false,
                "SupportsLocalWriteForwarding": true
            },
            {
                "Engine": "aurora-mysql",
                "EngineVersion": "8.0.mysql_aurora.3.08.0",
                "Description": "Aurora MySQL 3.08.0 (compatible with MySQL 8.0.39)",
                "AutoUpgrade": false,
                "IsMajorVersionUpgrade": false,
                "SupportedEngineModes": [
                    "provisioned"
                ],
                "SupportsParallelQuery": true,
                "SupportsGlobalDatabases": true,
                "SupportsBabelfish": false,
                "SupportsLocalWriteForwarding": true
            }
        ],
        "ExportableLogTypes": [
            "audit",
            "error",
            "general",
            "slowquery"
        ],
        "SupportsLogExportsToCloudwatchLogs": true,
        "SupportsReadReplica": false,
        "SupportedEngineModes": [
            "provisioned"
        ],
        "SupportedFeatureNames": [],
        "Status": "available",
        "SupportsParallelQuery": true,
        "SupportsGlobalDatabases": true,
        "MajorEngineVersion": "8.0",
        "SupportsBabelfish": false,
        "SupportsCertificateRotationWithoutRestart": true,
        "SupportedCACertificateIdentifiers": [
            "rds-ca-ecc384-g1",
            "rds-ca-rsa4096-g1",
            "rds-ca-rsa2048-g1"
        ],
        "SupportsLocalWriteForwarding": true
    }
]

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2 labels Dec 6, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team December 6, 2024 00:48
@hiromu-ootsuka hiromu-ootsuka marked this pull request as ready for review December 6, 2024 01:28
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Dec 6, 2024
@aws-cdk-automation aws-cdk-automation added pr/needs-maintainer-review This PR needs a review from a Core Team Member and removed pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Dec 6, 2024
Copy link

codecov bot commented Dec 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.67%. Comparing base (06cdaac) to head (514a9dd).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #32399      +/-   ##
==========================================
+ Coverage   78.66%   78.67%   +0.01%     
==========================================
  Files         107      107              
  Lines        7237     7237              
  Branches     1329     1329              
==========================================
+ Hits         5693     5694       +1     
+ Misses       1358     1357       -1     
  Partials      186      186              
Flag Coverage Δ
suite.unit 78.67% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 78.67% <ø> (+0.01%) ⬆️

Copy link
Contributor

mergify bot commented Dec 9, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 514a9dd
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

mergify bot commented Dec 9, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Dec 9, 2024
Copy link
Contributor

mergify bot commented Dec 9, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit f878e56 into aws:main Dec 10, 2024
20 checks passed
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants