-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: enforce eol-last rule #32335
chore: enforce eol-last rule #32335
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
Applied |
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
bcb2554
to
548db5a
Compare
548db5a
to
3d422bb
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #32335 +/- ##
==========================================
- Coverage 78.46% 78.42% -0.05%
==========================================
Files 106 106
Lines 7208 7208
Branches 1323 1323
==========================================
- Hits 5656 5653 -3
- Misses 1364 1368 +4
+ Partials 188 187 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
316b5ca
to
1abd85c
Compare
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Comments on closed issues and PRs are hard for our team to see. |
Reason for this change
This rule was previously not enforced and implementation inconsistent.
Enforcing a new line at the end of the file makes it easier to append files.
Description of changes
No code changes! Only formatting. 💅🏻
And a bit of config:
eol-last
Best reviewed with whitespace changes ignored: https://github.com/aws/aws-cdk/pull/32335/files?w=1
Description of how you validated changes
No code changes, purely formatting.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license