-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cli): proxy is not configured correctly #32213
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #32213 +/- ##
==========================================
- Coverage 77.19% 77.17% -0.02%
==========================================
Files 105 105
Lines 7166 7169 +3
Branches 1314 1315 +1
==========================================
+ Hits 5532 5533 +1
- Misses 1454 1455 +1
- Partials 180 181 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
# Conflicts: # packages/aws-cdk/THIRD_PARTY_LICENSES
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
➡️ PR build request submitted to A maintainer must now check the pipeline and add the |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Comments on closed issues and PRs are hard for our team to see. |
We were using the
localAddress
of the request handler options, which is the incorrect property. Instead, create an instance ofProxyAgent
, passing the CA certificate and a function that resolves to the proxy address option from the command line. If no proxy address was passed, it defaults to the environment variables.Tested manually using
mitmproxy
with a custom certificate.While testing this, I noticed that the retry strategy function was incorrect.
Closes #32208
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license