Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): proxy is not configured correctly #32213

Merged
merged 5 commits into from
Nov 20, 2024
Merged

Conversation

otaviomacedo
Copy link
Contributor

@otaviomacedo otaviomacedo commented Nov 20, 2024

We were using the localAddress of the request handler options, which is the incorrect property. Instead, create an instance of ProxyAgent, passing the CA certificate and a function that resolves to the proxy address option from the command line. If no proxy address was passed, it defaults to the environment variables.

Tested manually using mitmproxy with a custom certificate.

While testing this, I noticed that the retry strategy function was incorrect.

Closes #32208

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team November 20, 2024 15:33
@github-actions github-actions bot added the p2 label Nov 20, 2024
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Nov 20, 2024
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@aws-cdk-automation aws-cdk-automation added the pr/needs-cli-test-run This PR needs CLI tests run against it. label Nov 20, 2024
@otaviomacedo otaviomacedo added pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-test The PR linter will not require test changes and removed pr/needs-cli-test-run This PR needs CLI tests run against it. labels Nov 20, 2024
@aws-cdk-automation aws-cdk-automation added the pr/needs-cli-test-run This PR needs CLI tests run against it. label Nov 20, 2024
@github-actions github-actions bot added bug This issue is a bug. effort/medium Medium work item – several days of effort p1 and removed p2 labels Nov 20, 2024
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 77.17%. Comparing base (a8bc46d) to head (7165788).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #32213      +/-   ##
==========================================
- Coverage   77.19%   77.17%   -0.02%     
==========================================
  Files         105      105              
  Lines        7166     7169       +3     
  Branches     1314     1315       +1     
==========================================
+ Hits         5532     5533       +1     
- Misses       1454     1455       +1     
- Partials      180      181       +1     
Flag Coverage Δ
suite.unit 77.17% <60.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 77.17% <60.00%> (-0.02%) ⬇️
---- 🚨 Try these New Features:

# Conflicts:
#	packages/aws-cdk/THIRD_PARTY_LICENSES
@otaviomacedo otaviomacedo added the pr-linter/cli-integ-tested Assert that any CLI changes have been integ tested label Nov 20, 2024
@aws-cdk-automation aws-cdk-automation dismissed their stale review November 20, 2024 19:14

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation removed the pr/needs-cli-test-run This PR needs CLI tests run against it. label Nov 20, 2024
@aws-cdk-automation
Copy link
Collaborator

➡️ PR build request submitted to test-main-pipeline ⬅️

A maintainer must now check the pipeline and add the pr-linter/cli-integ-tested label once the pipeline succeeds.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 0192bf8
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

mergify bot commented Nov 20, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@otaviomacedo otaviomacedo merged commit ec58c77 into main Nov 20, 2024
14 of 15 checks passed
@otaviomacedo otaviomacedo deleted the otaviom/fix-proxy branch November 20, 2024 19:46
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug This issue is a bug. contribution/core This is a PR that came from AWS. effort/medium Medium work item – several days of effort p1 pr-linter/cli-integ-tested Assert that any CLI changes have been integ tested pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-test The PR linter will not require test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TimeoutError: read ECONNRESET since CDK CLI >= 2.167.0
3 participants