Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(release): 2.167.2 #32177

Merged
merged 5 commits into from
Nov 19, 2024
Merged

chore(release): 2.167.2 #32177

merged 5 commits into from
Nov 19, 2024

Commits on Nov 18, 2024

  1. fix(cli): cdk diff always falls back to template only diff (#32165) 

    Closes #32160

### Reason for this change

<!--What is the bug or use case behind this change?-->

When running `cdk deploy`, it is supposed to (by default) create a
read-only change set and incorporate it within the diff.
However, it currently fails creating the change-set and always falls
back to template only diffs.

### Description of changes

<!--What code changes did you make? Have you made any important design
decisions?-->

There was a wrong invocation of the `makeBodyParameter` parameter after
the [migration to sdk v3](#31702).

### Description of how you validated changes

Added missing integration tests. Unit test for this code are tricky
because they require too many mocks.

### Checklist
- [x] My code adheres to the [CONTRIBUTING
GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and
[DESIGN
GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache-2.0 license*
    @iliapolo
    iliapolo committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    3fd9699 View commit details
    Browse the repository at this point in the history

  2. fix(cli): the LoadBalancerProvider doesn't match LBs when querying by… 

    … a subset of tags (#32164)

There was a regression in the load balancer lookup, in which we started
requiring that the set of tags in the query is strictly the same as the
set of tags in the load balancer (rather than merely a subset of it).

Remove the length equality constraint and also simplify the code to make
the intent clearer.

Fixes #32161.

### Checklist
- [ ] My code adheres to the [CONTRIBUTING
GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and
[DESIGN
GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache-2.0 license*

Co-authored-by: Momo Kornher <[email protected]>
    @otaviomacedo @mrgrain @iliapolo
    2 people authored and iliapolo committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    a0b47c5 View commit details
    Browse the repository at this point in the history

  3. fix(cli): externally managed stack notification arns are deleted on `… 

    …deploy` (#32163)

Closes #32153.

### Reason for this change



When a stack contains externally managed notification ARNs (i.e ones that were added outside of CDK), a `cdk deploy` command will remove those ARNs.

### Description of changes



We incorrectly default notification ARNs to `[]` instead of `undefined`. When an empty array is passed to the SDK , it reasonably assumes you want to delete existing ARNs (because how otherwise would you delete them). If on the other hand you don't pass notification ARNs at all to the SDK (e.g `undefined`), it will preserve them.

This is the correct behavior and CDK should follow suite. This does however create a (maybe) quirky API ergonomic where in order to remove notification ARNs, one must pass `[]` instead of simply omitting the property. 

This stems from the fact notification ARNs are not managed through the template, but rather through imperative actions. So it seems reasonable al things considered. 

### Description of how you validated changes

Added both unit and integration tests.



### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
    @iliapolo
    iliapolo committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    465da31 View commit details
    Browse the repository at this point in the history

  4. chore(release): 2.167.2

    @iliapolo
    iliapolo committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    032c1a0 View commit details
    Browse the repository at this point in the history

  5. fix changelog headers

    @iliapolo
    iliapolo committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    fd68993 View commit details
    Browse the repository at this point in the history