feat(ses): add support to disable account-level suppression list #32168
+673
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
admired-contributor
github-actions
bot
added
effort/small
Tietew
commented
Nov 18, 2024
| }); | ||
| }); | ||
|
|
||
| test('override suppressionReasons to BOUNCES only', () => { |
There was a problem hiding this comment.
Tests for suppressionReasons are missing. So I also added.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #32168 +/- ##
=======================================
Coverage 77.18% 77.18%
=======================================
Files 105 105
Lines 7161 7161
Branches 1312 1312
=======================================
Hits 5527 5527
Misses 1454 1454
Partials 180 180
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Tietew
force-pushed
the
ses-disable-suppression-list
branch
from
8fc61d4
to
f0dabd3
Compare
aws-cdk-automation
added
the
pr/needs-community-review
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
mazyu36
reviewed
Nov 25, 2024
| You can also override account level settings with configuration set-level suppression enabled. Email sent with this configuration set will only use the suppression conditions you enabled for it (bounces, complaints, or bounces and complaints) - regardless of what your account-level suppression list settings are, it will override them. | ||
|
|
||
| ``` ts | ||
| // Only bouncs will be suppressed. |
There was a problem hiding this comment.
nit: typo
Suggested change
| // Only bouncs will be suppressed. | |
| // Only bounces will be suppressed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
Closes #32149.
Reason for this change
ConfigurationSet allows us to disable account-level suppression list but CDK missed the configuration.
Description of changes
Introduced
disableSuppressionListproperty to disable account-level suppression list.Description of how you validated changes
Added unit tests and integ test.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license