Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(s3-deployment): add security groups #32155

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

obraafo
Copy link

@obraafo obraafo commented Nov 16, 2024

expose securityGroups attribute of lambda underlying s3 bucket deployment to provide more control over connectivity rules

Issue # (if applicable)
Closes #.

Reason for this change
Provide more control over the network connectivity of lambda underlying s3 bucket deployment

Description of changes
Expose securityGroups attribute of s3 bucket deployment lambda

Description of how you validated changes
Added/updated unit tests.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added p2 beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK labels Nov 16, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team November 16, 2024 00:31
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@obraafo obraafo changed the title S3deploy sg feat(s3-deployment): add security groups Nov 16, 2024
obraafo and others added 2 commits November 16, 2024 04:21
expose securityGroups attribute of lambda underlying s3 bucket deployment to provide more control over connectivity rules
@aws-cdk-automation
Copy link
Collaborator

The pull request linter fails with the following errors:

❌ Features must contain a change to an integration test file and the resulting snapshot.

PRs must pass status checks before we can provide a meaningful review.

If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing Exemption Request and/or Clarification Request.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: d1e9535
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants