fix(scheduler-targets-alpha): kinesis data firehose target uses l1 instead of l2

[gracelu0]

Issue # (if applicable)

Tracking #31785

Reason for this change

Since the Kinesis Data Firehose Alpha module is in developer preview and contains the L2 construct for a Firehose Delivery Stream, we should make this upgrade from L1 to L2 now while the module is experimental instead of in the future, where we would need to add a V2 for this target (like for event targets, see #30189) to avoid breaking customers.

Description of changes

Replace CfnDeliveryStream with IDeliveryStream. The L1 uses S3DestinationConfiguration property whereas the L2 uses ExtendedS3DestinationConfiguration property (includes additional fields on top of S3DestinationConfiguration fields). According to
https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-kinesisfirehose-deliverystream.html, "If you change the delivery stream destination from an Amazon S3 destination to an Amazon ES destination, update requires some interruptions."

Description of how you validated changes

• Updated unit tests and integration test
• Deployed locally using CfnDeliveryStream then IDeliveryStream and verified the objects are written to the S3 bucket.

Checklist

• My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

BREAKING CHANGE: KinesisDataFirehosePutRecord scheduler target now accepts IDeliveryStream instead of CfnDeliveryStream.

[gracelu0]

This test setup was taken from https://github.com/aws/aws-cdk/blob/main/packages/%40aws-cdk/aws-kinesisfirehose-alpha/test/delivery-stream.test.ts

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.18%. Comparing base (50d11a3) to head (e377524).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #32150   +/-   ##
=======================================
  Coverage   77.18%   77.18%           
=======================================
  Files         105      105           
  Lines        7163     7163           
  Branches     1311     1311           
=======================================
  Hits         5529     5529           
  Misses       1454     1454           
  Partials      180      180           

Flag	Coverage Δ
suite.unit	77.18% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
packages/aws-cdk	77.18% <ø> (ø)

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[mrgrain]

@Mergifyio update

[mergify]

update

☑️ Nothing to do

• queue-position = -1 [📌 update requirement]
• #commits-behind > 0 [📌 update requirement]
• -closed [📌 update requirement]
• -conflict [📌 update requirement]

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: e377524
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[github-actions]

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.