chore: disable codecov from v2-release branch
#32125
Conversation
iliapolo
requested a deployment
to
test-pipeline
GitHub Actions
Waiting
| @@ -19,10 +21,10 @@ jobs: | |||
| uses: actions/setup-node@v4 | |||
|
|
|||
| - name: Install dependencies | |||
| run: cd packages/aws-cdk && yarn install | |||
There was a problem hiding this comment.
Because we don't need to cd here - it does the exact same thing without it.
|
|
||
| - name: Build CLI | ||
| run: cd packages/aws-cdk && npx lerna run build --scope=aws-cdk |
There was a problem hiding this comment.
Because we don't need to cd here - it does the exact same thing without it.
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
aws-cdk-automation
added
the
pr/needs-cli-test-run
| @@ -33,4 +35,4 @@ jobs: | |||
| directory: packages/aws-cdk/coverage | |||
| fail_ci_if_error: true | |||
| flags: suite.unit | |||
| token: ${{ secrets.CODECOV_TOKEN }} | |||
| use_oidc: true | |||
There was a problem hiding this comment.
Switch from token based authentication to OIDC. Verified to work here. This is really nice as it allows us to entirely remove the need for a long lived token.
See https://github.com/codecov/codecov-action?tab=readme-ov-file#using-oidc
| @@ -124,10 +124,10 @@ export class CloudWatchLogEventMonitor { | |||
| } | |||
|
|
|||
| private async tick(): Promise<void> { | |||
| // excluding from codecoverage because this | |||
There was a problem hiding this comment.
This is bizarre but i'm seeing sporadic behavior with respect to coverage of the if statement itself.
Our current report says its uncovered - but how can that be if the other lines of function ARE covered?
Lets disable this until we get to the bottom of it because it introduces sporadic coverage.
Followup to #32107.
| @@ -12,7 +12,8 @@ module.exports = { | |||
| lines: 81 | |||
| }, | |||
| }, | |||
| "coveragePathIgnorePatterns": [ | |||
| coveragePathIgnorePatterns: [ | |||
| ...baseConfig.coveragePathIgnorePatterns, | |||
There was a problem hiding this comment.
In #31702, we inadvertently overridden the base config, instead of adding to it. This caused our test utility files to be included in the coverage report.
See https://app.codecov.io/github/aws/aws-cdk/blob/main/packages%2Faws-cdk%2Ftest%2Fapi%2Ffake-sts.ts
iliapolo
added
the
pr-linter/cli-integ-tested
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #32125 +/- ##
==========================================
- Coverage 77.29% 77.14% -0.15%
==========================================
Files 114 105 -9
Lines 7627 7163 -464
Branches 1360 1311 -49
==========================================
- Hits 5895 5526 -369
+ Misses 1550 1457 -93
+ Partials 182 180 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
aws-cdk-automation
removed
the
pr/needs-cli-test-run
iliapolo
changed the title
v2-release branch
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
aws-cdk-automation
added
the
pr/needs-maintainer-review
aws-cdk-automation
removed
the
pr/needs-maintainer-review
|
Comments on closed issues and PRs are hard for our team to see. |
In #32082, we added codecov checks to mergify merge conditions.
This, as originally intended, blocked merging to both the
mainand thev2-releasebranches. However, we decided that currently we won't be applying codecov on thev2-releasebranch because it is redundant.Ideally, to achieve this, we would remove the conditions only from the mergify configuration that applies to the
v2-releasebranch. But our configuration isn't set up that way right now, it doesn't distinguish between branches.Luckily, mergify will automatically honor branch protection rules, so we can safely remove the branch dependant conditions from mergify all together, and keep them only in branch protection rules (which we already configured).
Once this PR is merged, I will also remove the codecov branch protection from
v2-release(but keep it onmain).Additional Changes
There's some additional codecov related cleanup we need to do so might as well. They are explained as review comments.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license