-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ecs-patterns): 32056 remove desired task count from ecs patterns #32077
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
Clarification Request |
The pull request linter fails with the following errors:
PRs must pass status checks before we can provide a meaningful review. If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week. |
Issue # (if applicable)
Closes #32056.
Reason for this change
desiredTaskCount is deprecated and not a property of the construct in use. Instead use of minCapacity and maxCapacity should be used.
Description of changes
Documentation specified that the user could use "desiredTaskCount " for the ecs-patterns construct. However "desiredTaskCount" is not a property of queueProcessingEc2Service, nor is desiredCount. Instead minCapacity and maxCapacity should be used to specify the count.
Description of how you validated changes
Updated unit tests, ran them, and created a successful build.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license