Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(events): match wildcard #32051

Closed
wants to merge 6 commits into from

Conversation

jaw111
Copy link

@jaw111 jaw111 commented Nov 7, 2024

Issue # (if applicable)

Closes #28462.

Reason for this change

Add support for wildcard match in event rules.

Description of changes

Added wildcard function on Match class.

Description of how you validated changes

Added test for wildcard function.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team November 7, 2024 13:34
@github-actions github-actions bot added beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2 labels Nov 7, 2024
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@jaw111 jaw111 changed the title aws_events match wildcard feat(aws_events): match wildcard Nov 7, 2024
@aws-cdk-automation aws-cdk-automation added pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Nov 7, 2024
@jaw111 jaw111 changed the title feat(aws_events): match wildcard feat(aws-events): match wildcard Nov 7, 2024
@jaw111 jaw111 changed the title feat(aws-events): match wildcard feat(events): match wildcard Nov 7, 2024
@aws-cdk-automation aws-cdk-automation removed the pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. label Nov 8, 2024
@aws-cdk-automation aws-cdk-automation dismissed their stale review November 8, 2024 07:53

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@jaw111 jaw111 force-pushed the 28462-aws-events-match-wildcard branch from 0da6234 to 1c0c3c2 Compare November 8, 2024 08:20
@jaw111 jaw111 closed this Nov 8, 2024
Copy link

github-actions bot commented Nov 8, 2024

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 8, 2024
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 1c0c3c2
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2 pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(aws-events): EventPattern support for wildcard filters
2 participants