-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(scheduler-targets-alpha): add dlq policy to execution role instead of queue policy #32032
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
fe85775
to
5eebbf8
Compare
For integ test, you can write one similar to integ.schedule.ts but intentionally have missing target invocation permission in the execution role. A rate-based schedule without time window is invoked right away when created. Then use assert to check the queue has the expected message. |
packages/@aws-cdk/aws-scheduler-targets-alpha/test/codebuild-start-build.test.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Addressed comments and he is on vacation so I am not going to bother him more
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
Tracking #31785.
Reason for this change
Currently if a dead letter queue (DLQ) is specified then a queue policy is created for the DLQ which allows the schedule to send messages. This is incorrect and the permissions should be added to the schedule's execution role instead.
Description of changes
Add
sqs:SendMessage
permission to execution role's policy statement if dead letter queue is specified. This follows the service docs for configuring a schedule DLQ.Also removed cross-region validation as the deployment will fail fast for this case so the validation is unnecessary.
Description of how you validated changes
Updated unit tests and added a new integration test with dead letter queue setup on the schedule
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license