Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(codepipeline): generate stack name in codepipeline when stack name is unresolved token #31967

Merged
merged 13 commits into from
Nov 7, 2024

Conversation

GavinZZ
Copy link
Contributor

@GavinZZ GavinZZ commented Oct 31, 2024

Issue # (if applicable)

Closes #31436.

Reason for this change

When nested stack is used with CodePipeline, the stack name is actually a token which will fail regex check. We can't simply add a Token.isUnresolved check before the regex check because stack name must be a resolved string otherwise the template file would include Token[xxx].

Description of changes

The only feasible fix would be allowing users to override the nested stack name if users provide one. Currently nested stack names are auto-generated and are a token value. Allow users to specify the stack name.

Description of how you validated changes

New integ tests pass. Existing tests pass.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@GavinZZ
Copy link
Contributor Author

GavinZZ commented Oct 31, 2024

Pending integration test.

@github-actions github-actions bot added bug This issue is a bug. effort/small Small work item – less than a day of effort p1 labels Oct 31, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team October 31, 2024 20:38
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Oct 31, 2024
@GavinZZ GavinZZ changed the title chore: only validate regex if stack name is not a token chore(core): allow customer provided stack name for nested stack Nov 1, 2024
@GavinZZ GavinZZ marked this pull request as ready for review November 1, 2024 19:15
@GavinZZ GavinZZ marked this pull request as draft November 1, 2024 21:00
@GavinZZ GavinZZ changed the title chore(core): allow customer provided stack name for nested stack chore(codepipeline): generate stack name in codepipeline when stack name is unresolved token Nov 1, 2024
@GavinZZ GavinZZ marked this pull request as ready for review November 1, 2024 23:35
@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Nov 4, 2024
Copy link
Member

@Leo10Gama Leo10Gama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good, just a few minor comments. The description also mentions unit tests added but I only see an integ test change. If we can only see the changes in effect when deploying, it should be fine to omit unit tests, but we should update the PR description.

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Nov 5, 2024
Copy link
Member

@Leo10Gama Leo10Gama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@Leo10Gama
Copy link
Member

@Mergifyio update

Copy link
Contributor

mergify bot commented Nov 7, 2024

update

✅ Branch has been successfully updated

Copy link
Contributor

mergify bot commented Nov 7, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 4a13c45
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit a09ccdb into main Nov 7, 2024
12 checks passed
Copy link
Contributor

mergify bot commented Nov 7, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot deleted the yuanhaoz/stack_name_check branch November 7, 2024 23:27
Copy link

github-actions bot commented Nov 7, 2024

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug This issue is a bug. contribution/core This is a PR that came from AWS. effort/small Small work item – less than a day of effort p1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(codepipeline): CrossRegionSupportStack Stack name must match the regular expression
3 participants