-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(cli): generate yargs configuration from TS #31850
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
…m our standard build to not break something
I'm a inclined the check the generated code in for visibility and reviewability. WDYT? |
My first instinct was to follow the codegen pattern we have for L1s, which is to ignore them, but the nature of the |
➡️ PR build request submitted to A maintainer must now check the pipeline and add the |
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
N/A
Reason for this change
We'd like to create a programmatic interface to the CDK Toolkit. A bonus of this overhaul is moving to a single source of truth for both the programmatic interface to the CDK Toolkit and the command line interface to the CDK Toolkit. This PR generates the existing
yargs
configuration from a TS configuration. In the long term, we'd generate theyargs
configuration purely from the programmatic interface to the Toolkit, but this is an improvement with less effort.Description of changes
Creates a new package,
@aws-cdk/yargs-gen
, which generates ouryargs
configuration from aCliConfig
defined inaws-cdk/config.ts
using@cdklabs/typewriter
.Description of how you validated changes
N/A yet.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license