Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(scheduler-targets-alpha): imported lambda function as schedule target throws synth error #31837

Merged
merged 10 commits into from
Oct 23, 2024

Conversation

samson-keung
Copy link
Contributor

@samson-keung samson-keung commented Oct 21, 2024

Issue # (if applicable)

Closes #29284.

Tracking #31785.

Reason for this change

Removed the same env check between the Schedule and the Lambda target to allow use of imported Lambda function as target.

Description of changes

Removed the check that forces the Schedule and the Lambda function to be in the same account and region.

Description of how you validated changes

  • Unit test added to ensure no synth error when using imported Lambda function.
  • Integ test added to ensure imported function works. The test ensures the lambda is executed and did what it is supposed to do (i.e. added tag to itself).

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added bug This issue is a bug. effort/medium Medium work item – several days of effort p1 labels Oct 21, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team October 21, 2024 19:15
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Oct 21, 2024
@samson-keung samson-keung requested a review from gracelu0 October 21, 2024 20:27
@samson-keung samson-keung marked this pull request as ready for review October 21, 2024 20:27
@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Oct 21, 2024
}

protected addTargetActionToRole(schedule: ISchedule, role: IRole): void {
if (!sameEnvDimension(this.func.env.region, schedule.env.region)) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this would fix the problem mentioned in the issue, I don't think this is a good fix in general since it removes check even for functions and scheduler with known account & regions.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is correct. The reasoning to remove the check is explained here.

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Oct 21, 2024
@gracelu0
Copy link
Contributor

What is the deployment behaviour now without this validation if the account/region don't match? Is there any documentation on this restriction? I wasn't able to find anything.

@samson-keung
Copy link
Contributor Author

What is the deployment behaviour now without this validation if the account/region don't match? Is there any documentation on this restriction? I wasn't able to find anything.

From my testing, different account works (although not explicitly documented). Different region will throw error at template deploy time.

Copy link
Contributor

mergify bot commented Oct 22, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Copy link
Contributor

mergify bot commented Oct 22, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: f8455bc
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit d1d179f into aws:main Oct 23, 2024
12 checks passed
Copy link
Contributor

mergify bot commented Oct 23, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug This issue is a bug. contribution/core This is a PR that came from AWS. effort/medium Medium work item – several days of effort p1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(aws-scheduler-targets-alpha): Cannot use imported function ARN with LambdaInvoke target
4 participants