Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(elasticloadbalancingv2): support target group level cross-zone settings for ALB and NLB #31814

Merged
merged 13 commits into from
Nov 14, 2024

Conversation

mazyu36
Copy link
Contributor

@mazyu36 mazyu36 commented Oct 19, 2024

Issue # (if applicable)

Closes #31790.

Reason for this change

To support target group level cross-zone settings for ALB and NLB

Description of changes

Add crossZoneEnabled property to baseTargetGroup.

Description of how you validated changes

Add unit tests and integ tests.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 labels Oct 19, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team October 19, 2024 05:18
@github-actions github-actions bot added the distinguished-contributor [Pilot] contributed 50+ PRs to the CDK label Oct 19, 2024
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@mazyu36 mazyu36 marked this pull request as ready for review October 19, 2024 07:20
@aws-cdk-automation aws-cdk-automation dismissed their stale review October 19, 2024 07:22

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Oct 19, 2024
@@ -805,4 +805,29 @@ describe('tests', () => {
});
});

// test cases for crossZoneEnabled
describe('crossZoneEnabled', () => {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Handle the undefined case also?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a test case.


// test cases for crossZoneEnabled
describe('crossZoneEnabled', () => {
test.each([true, false])('crossZoneEnabled can be %s', (crossZoneEnabled) => {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Handle the undefined case also?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a test case.

@aws-cdk-automation aws-cdk-automation added pr/needs-maintainer-review This PR needs a review from a Core Team Member and removed pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Nov 2, 2024
@Leo10Gama Leo10Gama self-assigned this Nov 8, 2024
Copy link
Member

@Leo10Gama Leo10Gama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! Just a few small nit-picks from me, otherwise looks good!

Comment on lines 843 to 848
TargetGroupAttributes: [
{
Key: 'stickiness.enabled',
Value: 'false',
},
],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Is this attribute always present for the ALB target group? This test could be clearer using Match.absent() like the NLB, but no worries if this can't be helped.

Copy link
Contributor Author

@mazyu36 mazyu36 Nov 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.
I've update the test to TargetGroupAttributes to be undefined by using Lambda Target Type.

packages/aws-cdk-lib/aws-elasticloadbalancingv2/README.md Outdated Show resolved Hide resolved
@mazyu36
Copy link
Contributor Author

mazyu36 commented Nov 13, 2024

@Mergifyio refresh

Copy link
Contributor

mergify bot commented Nov 13, 2024

refresh

✅ Pull request refreshed

Leo10Gama
Leo10Gama previously approved these changes Nov 13, 2024
Copy link
Member

@Leo10Gama Leo10Gama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contribution!

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Nov 13, 2024
Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.17%. Comparing base (d14a01c) to head (8dd0535).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #31814   +/-   ##
=======================================
  Coverage   77.17%   77.17%           
=======================================
  Files         105      105           
  Lines        7162     7162           
  Branches     1311     1311           
=======================================
  Hits         5527     5527           
  Misses       1455     1455           
  Partials      180      180           
Flag Coverage Δ
suite.unit 77.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 77.17% <ø> (ø)

Copy link
Contributor

mergify bot commented Nov 13, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@Leo10Gama
Copy link
Member

@Mergifyio update

Copy link
Contributor

mergify bot commented Nov 13, 2024

update

❌ Mergify doesn't have permission to update

For security reasons, Mergify can't update this pull request. Try updating locally.
GitHub response: refusing to allow a GitHub App to create or update workflow .github/workflows/codecov.yml without workflows permission

@mergify mergify bot dismissed Leo10Gama’s stale review November 13, 2024 19:11

Pull request has been modified.

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Nov 13, 2024
Copy link
Contributor

mergify bot commented Nov 14, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 8dd0535
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 6b0b1e1 into aws:main Nov 14, 2024
17 checks passed
Copy link
Contributor

mergify bot commented Nov 14, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 14, 2024
@mazyu36 mazyu36 deleted the target-group-crosszone branch November 14, 2024 22:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
distinguished-contributor [Pilot] contributed 50+ PRs to the CDK effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 pr/needs-maintainer-review This PR needs a review from a Core Team Member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(elasticloadbalancingv2): Configure cross-zone load balancing for ALB target groups
5 participants