Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(toolkit): do not deploy empty stacks #3144

Merged
merged 16 commits into from
Aug 28, 2019
Merged

fix(toolkit): do not deploy empty stacks #3144

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
98e018d
fix(toolkit): do not deploy empty stacks
jogold Jul 1, 2019
912a697
use warning
jogold Jul 1, 2019
b6f5c0a
Merge branch 'master' into empty-stacks
RomainMuller Aug 7, 2019
44e4097
Merge branch 'master' into empty-stacks
jogold Aug 21, 2019
fea60a1
destroy empty stack if it exists
jogold Aug 22, 2019
c18fb0a
change mode to ForReading
jogold Aug 22, 2019
6d22f09
force destroy
jogold Aug 26, 2019
1443dae
optional roleArn
jogold Aug 26, 2019
4195fb6
remove 'skipping deployment' when destroying
jogold Aug 26, 2019
4831ac8
set exclusively to true
jogold Aug 26, 2019
22d936a
make deployesque
jogold Aug 26, 2019
9376e1c
add integ test
jogold Aug 27, 2019
cd13fb4
Merge branch 'master' into empty-stacks
shivlaks Aug 27, 2019
89efa00
Merge branch 'master' into empty-stacks
shivlaks Aug 28, 2019
e269d8b
Merge branch 'master' into empty-stacks
shivlaks Aug 28, 2019
082caea
Merge branch 'master' into empty-stacks
mergify[bot] Aug 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/aws-cdk/lib/cdk-toolkit.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,11 @@ export class CdkToolkit {
throw new Error(`Stack ${stack.name} does not define an environment, and AWS credentials could not be obtained from standard locations or no region was configured.`);
}

if (Object.keys(stack.template.Resources || {}).length === 0) {
print('%s: stack has no resources, skipping deployment.', colors.bold(stack.name));
jogold marked this conversation as resolved.
Show resolved Hide resolved
continue;
}

if (requireApproval !== RequireApproval.Never) {
const currentTemplate = await this.provisioner.readCurrentTemplate(stack);
if (printSecurityDiff(currentTemplate, stack, requireApproval)) {
Expand Down