Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(efs): allow AccessPoint to set client token #31184

Merged
merged 5 commits into from
Oct 18, 2024

Conversation

perrylson
Copy link
Contributor

@perrylson perrylson commented Aug 22, 2024

Reason for this change

The CfnAccessPoint construct supports client token specification. However, the current L2 implementation of AccessPoint does not support this property.

The disable-update-workflow option was needed when running the updated integration test.

Description of changes

Added the clientToken prop to the existing props of AccessPoint.

Description of how you validated changes

Validated with unit and integration testing.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2 labels Aug 22, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team August 22, 2024 15:43
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Aug 22, 2024
This was referenced Aug 26, 2024
Copy link
Contributor

@badmintoncryer badmintoncryer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! I've added some comments.

packages/aws-cdk-lib/aws-efs/README.md Outdated Show resolved Hide resolved
packages/aws-cdk-lib/aws-efs/lib/access-point.ts Outdated Show resolved Hide resolved
packages/aws-cdk-lib/aws-efs/lib/access-point.ts Outdated Show resolved Hide resolved
packages/aws-cdk-lib/aws-efs/lib/access-point.ts Outdated Show resolved Hide resolved
@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Oct 3, 2024
Copy link
Contributor

@badmintoncryer badmintoncryer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I am proposing just one refactor, but I approve it.

packages/aws-cdk-lib/aws-efs/test/access-point.test.ts Outdated Show resolved Hide resolved
@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Oct 3, 2024
Copy link
Contributor

@GavinZZ GavinZZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one minor update to the validation part to make it clearer.

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Oct 16, 2024
GavinZZ
GavinZZ previously approved these changes Oct 17, 2024
Copy link
Contributor

mergify bot commented Oct 17, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot dismissed GavinZZ’s stale review October 18, 2024 03:47

Pull request has been modified.

@perrylson perrylson requested a review from GavinZZ October 18, 2024 03:48
Copy link
Contributor

mergify bot commented Oct 18, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 6b48d2d
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 8208774 into aws:main Oct 18, 2024
9 checks passed
Copy link
Contributor

mergify bot commented Oct 18, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants