Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(iam): incorrect input for AccountPrincipal is building successfully #30559

Closed
wants to merge 32 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
32b81d6
fix(iam) add 12-digits validation for AccountPrincipal
duranbe Jun 15, 2024
dfa6d2b
fix(iam): add 12-digits validation for AccountPrincipal -fix double q…
duranbe Jun 15, 2024
5377e35
Update principals.test.ts
duranbe Jun 26, 2024
bafdb58
Update principals.ts
duranbe Jun 26, 2024
4ca3cdd
Update principals.ts
duranbe Jun 26, 2024
f62de18
Update principals.test.ts
duranbe Jun 26, 2024
c417abc
Update principals.ts
duranbe Jun 26, 2024
eb4c436
Fix with !cdk.Token.isUnresolved(accountId)
duranbe Jun 29, 2024
23afbdf
Fix few test with incorrect mock AWS account id
duranbe Jun 29, 2024
e16f43b
Fix test with incorrect Account Id
duranbe Jun 30, 2024
599d0f5
Fix allowed account id in test
duranbe Jul 1, 2024
f276c65
fix bootstrap test
duranbe Jul 1, 2024
0de4548
fix bootstrap test - 2
duranbe Jul 1, 2024
5269a4c
fix integ test
duranbe Jul 1, 2024
b22e556
fix integ test?
duranbe Jul 1, 2024
79ba4d1
Merge branch 'main' into fix-account-principal
duranbe Jul 9, 2024
3d208b2
Merge branch 'aws:main' into fix-account-principal
duranbe Jul 10, 2024
9d4c411
fix test
duranbe Jul 10, 2024
de3fbe8
Merge branch 'main' into fix-account-principal
duranbe Jul 14, 2024
23afb1c
Update principals.test.ts
duranbe Jul 14, 2024
1f73435
fix indent
duranbe Jul 14, 2024
8a6861a
Merge branch 'main' into fix-account-principal
duranbe Jul 15, 2024
04d3573
Merge branch 'main' into fix-account-principal
duranbe Jul 17, 2024
9a71f48
Merge branch 'main' into fix-account-principal
duranbe Jul 22, 2024
dfd66cb
Merge branch 'main' into fix-account-principal
duranbe Jul 27, 2024
4c9b2ca
Merge branch 'main' into fix-account-principal
duranbe Jul 30, 2024
b73f17f
Merge branch 'main' into fix-account-principal
duranbe Aug 8, 2024
15901f2
fix(lambda-nodejs): breaking change in esbuild causes import module e…
xazhao Jul 1, 2024
e5e032b
chore: remove use of deprecated ServicePrincipal Mapping (#30832)
TheRealAmazonKendra Jul 12, 2024
454744b
Update principals.test.ts
duranbe Jul 14, 2024
1aa09bb
fix indent
duranbe Jul 14, 2024
eb7276b
feat(ec2): security group lookup via filters (#30625)
jdukewich Aug 7, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,9 @@ import * as cpactions from 'aws-cdk-lib/aws-codepipeline-actions';
*
* Outputs:
* aws-cdk-codepipeline-ecr-source.PipelineConsoleLink = https://us-east-1.console.aws.amazon.com/codesuite/codepipeline/pipelines/aws-cdk-codepipeline-ecr-source-MyPipelineAED38ECF-1P0OYRLWF8FHY/view?region=us-east-1
* aws-cdk-codepipeline-ecr-source.LoginCommand = aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 11111111111.dkr.ecr.us-east-1.amazonaws.com
* aws-cdk-codepipeline-ecr-source.PushCommand = docker tag public.ecr.aws/lambda/provided 11111111111.dkr.ecr.us-east-1.amazonaws.com/aws-cdk-codepipeline-ecr-source-myecrrepo767466d0-gsrntpvfwc5w:latest \
* && docker push 11111111111.dkr.ecr.us-east-1.amazonaws.com/aws-cdk-codepipeline-ecr-source-myecrrepo767466d0-gsrntpvfwc5w:latest
* aws-cdk-codepipeline-ecr-source.LoginCommand = aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 111111111111.dkr.ecr.us-east-1.amazonaws.com
* aws-cdk-codepipeline-ecr-source.PushCommand = docker tag public.ecr.aws/lambda/provided 111111111111.dkr.ecr.us-east-1.amazonaws.com/aws-cdk-codepipeline-ecr-source-myecrrepo767466d0-gsrntpvfwc5w:latest \
* && docker push 111111111111.dkr.ecr.us-east-1.amazonaws.com/aws-cdk-codepipeline-ecr-source-myecrrepo767466d0-gsrntpvfwc5w:latest
duranbe marked this conversation as resolved.
Show resolved Hide resolved
*
* Run the LoginCommand & PushCommand to tag and push an image to the ECR repository.
* Then use the PipelineConsoleLink to navigate to the pipeline console page to validate that the pipeline
Expand Down
Loading
Loading