-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(codepipeline): auto rollback for pipeline #30465
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
The pull request linter fails with the following errors:
PRs must pass status checks before we can provide a meaningful review. If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
I think that we are getting too many features that are only available on pipelines v2 to keep adding properties to the same construct. It's probably time that we make a PipelineV2 instead of just adding more props that only work in specific circumstances. |
I see. I think it is good to work on this issue after the V2 construct is completed, so I will close this PR for the time being. |
Hi, is there an issue I can follow for the V2 construct? |
TODO
onFailure
andFailureConditions
as per CFn or have a boolean type likeautoRollback
. I think customizing it for CDK is a good design, but given the recent CodePipeline trend and its CFn structure, there may be extensions to this in the future.failureConditionsResult
as an enum type tostageProps
instead ofonFailure
(FailureConditions
) to prevent nesting.autoRollback
property for now and deprecate it if the structureFailureConditions
is needed in the future.Issue # (if applicable)
Closes #30083.
Reason for this change
Description of changes
WIP
Description of how you validated changes
WIP
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license